Alex Miller
Alex Miller
Would be extremely helpful to have these added :)
Not for counting backslashes specifically but more for validating the tokens are supported, i.e. the standard implementation of grep doesn't support `\d` (or perlre in general)
Looks good to me 👍 The interface `SetViewportOptions` already has `padding` in it so the option should be exposed correctly. @EddyVerbruggen safe to merge this imo
Looks like a reasonably nice solution to the problems reported 👌 was looking at doing this too
FYI I've been working on bringing this package up to date and resolving the build issues as well, if there were any concerns around merging this despite the build failing....
PR opened to resolve the build issues amongst other things. These changes don't break the build (tested locally): https://github.com/EddyVerbruggen/nativescript-mapbox/pull/311
Tested these changes on my branch, all seems 👌
@lochstar my PR was accepted, so you'll need to resolve / rebase probably.
Probably won't until the failing build is resolved?
Very keen to see this added! Some solid examples around now for both iOS and Android. Edit: Oh, as said previously, it's already there: https://github.com/EddyVerbruggen/nativescript-mapbox/blob/master/src/mapbox.common.ts#L187