Igor Żuk

Results 110 comments of Igor Żuk

Yes, we're discussing a solution to a specific problem and its relation to a bigger picture.

There seems to be a misunderstanding, I want to **add** the installation scripts, not replace any existing ones, `build-release` would be kept untouched. >I always read "build from source", so...

> Unless somebody uses cargo build --release alone this we could just adjust these scripts. Sometimes I do use cargo directly, sometimes I'm using a custom script. I think that...

I've verified it and it's true: https://github.com/rust-lang/rustup#installation

Sure! Just to be clear, the core of this proposal are the **constants with chain IDs**, the rest like `chainName` are nice extras which may or may not be worth...

Thanks for looking into it and benchmarking this approach so quickly! I'm surprised by the results, but if you would be interested in merging a refactoring like this, I'll look...

I did a very quick benchmark of your code with solc 0.8.24, via-IR and 1B optimizer runs. On my side the results are **very** good, about 1/3 gas saving: |...

That's a good observation, with the legacy pipeline and 200 runs the results are mixed, and often the current approach is cheaper. What's a bit concerning is that both versions...

That's a good concern, a puppet is incompatible with the `safeTransfer` functionality. I'm working on the formal ERC, I'll post a link it here. TBF I completely agree with your...

Here's the full ERC: https://github.com/ethereum/ERCs/pull/236