Fabrik icon indicating copy to clipboard operation
Fabrik copied to clipboard

Published 20 hours ago • verified publisher icon Cloud-CV

Fix #318: fixed datatype error

Open Shivanshmundra opened this issue 7 years ago • 4 comments

Fix #318: Fixed datatype error This fixes the issue #318 Don't throw error when some specific parameters value is edited while model is exported. Checked by again importing the same model showing same values of edited parameters.

Shivanshmundra avatar Mar 01 '18 17:03 Shivanshmundra

Coverage Status

Coverage remained the same at 95.442% when pulling 4cb745571f16e55db8cc1e105fe303d958686ffc on Shivanshmundra:floatTonumber into 062db16e28f2e0711910f2cad2ba590a45f7d5cc on Cloud-CV:master.

coveralls avatar Mar 01 '18 17:03 coveralls

@Shivanshmundra Thanks for reporting the bug and the fix. But the error seems to persist even after this. Steps to recreate:

  • Load ResNet-101 model from the model zoo
  • Change value of moving average fraction in the batch norm layer
  • Try exporting

utsavgarg avatar Mar 15 '18 15:03 utsavgarg

@Shivanshmundra it would be better to parse values at the time of layer update. If you need help with update part we can discuss.

Ram81 avatar Mar 15 '18 17:03 Ram81

@utsavgarg @Ram81 I figured out the error, Actually by default each value is parsed as string. Now there is exception to parse value as integer but there was no exception for float so I added it and now its working fine. Have a review.

Shivanshmundra avatar Mar 17 '18 07:03 Shivanshmundra