tarp icon indicating copy to clipboard operation
tarp copied to clipboard

add: missing dependencies to import tarp module in python REPL

Open psteinb opened this issue 1 year ago • 1 comments

Hi, thanks so much for the providing the code to your publication. I wanted to reproduce the code and ran into some troubles regarding missing dependencies. This PR tries to fix that. Best

psteinb avatar Mar 21 '24 15:03 psteinb

cc @Pablo-Lemos. Could you please review this?

matthewfeickert avatar May 16 '24 12:05 matthewfeickert

Great to see these approvals. Thanks for the support. But someone has to push the merge button eventually.

psteinb avatar Jun 27 '24 20:06 psteinb

pablo is on leave. Can anyone else merge?

On Thu, Jun 27, 2024 at 4:30 PM Peter Steinbach @.***> wrote:

Great to see these approvals. Thanks for the support. But someone has to push the merge button eventually.

— Reply to this email directly, view it on GitHub https://github.com/Ciela-Institute/tarp/pull/6#issuecomment-2195617154, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFPE5YULAZ7J2L6DASV23LZJRY6NAVCNFSM6AAAAABFBXJWUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGYYTOMJVGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

yasharhezaveh avatar Jun 27 '24 22:06 yasharhezaveh

I think Pablo is the only reviewer with write access so we are a bit stuck on our end. Maybe Adam can do it

EnceladeCandy avatar Jul 03 '24 15:07 EnceladeCandy

Maybe Adam can do it

cc @adam-coogan

matthewfeickert avatar Jul 03 '24 15:07 matthewfeickert

Thanks very much for the merge, @EnceladeCandy. 👍 Can you also please make a patch release to PyPI?

matthewfeickert avatar Jul 04 '24 16:07 matthewfeickert