Java-OCA-OCPP

Java-OCA-OCPP copied to clipboard

Trying to build the current master using the command "./gradlew build" yields failures in code style verifications and tests.

These files are not formatted correctly:

ocpp-common/src/main/java/eu/chargetime/ocpp/AsyncPromiseFulfillerDecorator.java ocpp-common/src/main/java/eu/chargetime/ocpp/Client.java ocpp-v1_6/src/main/java/eu/chargetime/ocpp/IClientAPI.java OCPP-J/src/main/java/eu/chargetime/ocpp/JSONCommunicator.java OCPP-J/src/main/java/eu/chargetime/ocpp/WebSocketListener.java

And these tests are failing:

Task :v1_6-test:test

eu.chargetime.ocpp.test.profiles.core.json.JSONGetConfigurationSpec > Central System sends a GetConfiguration request and receives a response FAILED java.lang.NullPointerException at JSONGetConfigurationSpec.groovy:12

eu.chargetime.ocpp.test.profiles.firmware.json.JSONFirmwareStatusNotificationSpec > Charge point sends a FirmwareStatusNotification request and receives a response FAILED org.spockframework.runtime.SpockTimeoutError at JSONFirmwareStatusNotificationSpec.groovy:46 Caused by: org.spockframework.runtime.ConditionNotSatisfiedError at JSONFirmwareStatusNotificationSpec.groovy:47

eu.chargetime.ocpp.test.profiles.firmware.json.JSONGetDiagnosticsSpec > Central System sends a GetDiagnostics request and receives a response FAILED eu.chargetime.ocpp.UnsupportedFeatureException at JSONGetDiagnosticsSpec.groovy:42

eu.chargetime.ocpp.test.profiles.firmware.json.JSONDiagnosticsStatusNotificationSpec > Central System sends a DiagnosticsStatusNotification request and receives a response FAILED org.spockframework.runtime.SpockTimeoutError at JSONDiagnosticsStatusNotificationSpec.groovy:46 Caused by: org.spockframework.runtime.ConditionNotSatisfiedError at JSONDiagnosticsStatusNotificationSpec.groovy:47

eu.chargetime.ocpp.test.profiles.firmware.json.JSONUpdateFirmwareSpec > Central System sends a UpdateFirmware request and receives a response FAILED eu.chargetime.ocpp.UnsupportedFeatureException at JSONUpdateFirmwareSpec.groovy:46

49 tests completed, 5 failed

Task :v1_6-test:test FAILED

Also, build.gradle appears to have an outdated version number:

version = '0.5-SNAPSHOT'

Furthermore, the "pom.xml" files have "1.0.2" in them, but shouldn't it be "1.0.2-SNAPSHOT"...?

1.0.2

Edit: I think this commit broke most of the tests: https://github.com/ChargeTimeEU/Java-OCA-OCPP/pull/176/commits/fb53e2dbb7680f4ff137fa67aa740164685b4657

I did not understand why this was correct anyway. Did this commit break the FirmwareManagement profile in OCPP 1.6?

@robert-s-ubi working now?

The issue has been fixed since.