argo-python-dsl
argo-python-dsl copied to clipboard
CermakM
Workflow metadata name parsed from class name prevents generated name from working
Description Is it a design decision that any workflow class would have it's name attr set as "class-name" by default? While the metadata name is set, generated name will not take action.
e.g. class Helloworld(Workflow) would have 'hello-world' set as metadata name by default and used as pod name explicitly in k8s. I like the idea of leaving the name empty (or optional?) and default to generated-names, so I can submit the same workflow multiple times (since we cannot have duplicate pod names in k8s, at least while using the same node )
this is no a show stopper for me, I can always call wf.name = '', but current behaviour seems counter-intuitive.
Additional context https://github.com/CermakM/argo-python-dsl/blob/master/argo/workflows/dsl/_workflow.py#L67
now this works at https://github.com/argoproj-labs/argo-python-dsl/
if generate-name is specified then name is ommited
