GitHub-ReadMe icon indicating copy to clipboard operation
GitHub-ReadMe copied to clipboard

🐞 [BUG_LP] - Remove the newsletter's email field.

Open kadambari68 opened this issue 2 years ago • 9 comments

Description of the bug. ✍🏻

No server-side validations on the newsletter's email field as required can be removed from the inspect and malicious actors can bypass client-side validation.

Current Behaviour

When we click on the subscribe button keeping the newsletter's email field empty it didn't give any message to enter an email or the field should not be empty.

Expected Behaviour

There should be email validations on that field which can check and identify correct email addresses at the server side.

Reproduction Steps

1. Go to a landing page
2. Click on subscribe button
3. No error message like the field is required

Screenshots

cats

Additional information

I can fix it by using JavaScript

Contributor terms

  • [X] I agree to follow the Contributing Instructions

kadambari68 avatar Jun 03 '23 11:06 kadambari68

Hello @kadambari68! Thank you for raising this issue.

Please make sure to follow our Contributing Guidelines. 💪🏻 Don't forget to ⭐ our GitHub-ReadMe. 📃

Our review team will carefully assess the issue and reach out to you soon! 😇 We appreciate your patience! 😀

github-actions[bot] avatar Jun 03 '23 11:06 github-actions[bot]

I guess we need to remove this... Coz the content needs to be decided. I don't think we'll have a newsletter field. Wanna remove it?

praveenscience avatar Jun 03 '23 12:06 praveenscience

Yes sure but will that count as a contribution too?

kadambari68 avatar Jun 03 '23 12:06 kadambari68

Yep, definitely.

praveenscience avatar Jun 03 '23 12:06 praveenscience

ok then sure

kadambari68 avatar Jun 03 '23 12:06 kadambari68

Shall I remove all the points in the description section or is it ok to start working without it

kadambari68 avatar Jun 03 '23 12:06 kadambari68

Give your first attempt, will do more soon! 😊

praveenscience avatar Jun 03 '23 12:06 praveenscience

Then can you assign it to me

kadambari68 avatar Jun 03 '23 12:06 kadambari68

@kadambari68 Yours...

praveenscience avatar Jun 03 '23 13:06 praveenscience