GitHub-ReadMe icon indicating copy to clipboard operation
GitHub-ReadMe copied to clipboard

Published 20 hours ago • verified publisher icon CatsInTech

🚀 [Refactor_WebApp] - Change the router

Open kailashchoudhary11 opened this issue 2 years ago • 4 comments

Description of the enhancement. ✍🏻

We can change the router to RouterProvider instead of BrowserRouter this will allow us to use the data APIs like loaders and actions. What do you think 🤔

Describe briefly how you would implement this enhancement.

By importing the required functions and components.

Screenshots Example (if applicable)

No response

Additional information

No response

Contributor terms

  • [X] I agree to follow the Contributing Instructions

kailashchoudhary11 avatar May 31 '23 14:05 kailashchoudhary11

Hello @kailashchoudhary11! Thank you for raising this issue.

Please make sure to follow our Contributing Guidelines. 💪🏻 Don't forget to ⭐ our GitHub-ReadMe. 📃

Our review team will carefully assess the issue and reach out to you soon! 😇 We appreciate your patience! 😀

github-actions[bot] avatar May 31 '23 14:05 github-actions[bot]

Why is this better? Coz I tried this and seemed complicated. Also we don't even need Router, I'd say, remove the router?

praveenscience avatar May 31 '23 15:05 praveenscience

Why is this better? Coz I tried this and seemed complicated. Also we don't even need Router, I'd say, remove the router?

Aren't we planning on adding more pages?

kailashchoudhary11 avatar May 31 '23 15:05 kailashchoudhary11

What pages are we planning to add? Just thinking about the scope of the project! 😊

praveenscience avatar May 31 '23 18:05 praveenscience