Carson Full
Carson Full
Looks good :+1:
This looks good to me :+1: How's this for the routes section? ``` js "routes": { "route name": { "controller" : "FooClass::barMethod", // Or some kind of signature "requirements": {...
Although I have to say I cringe at version constants in code. They are a pain for release management. Is that maintains cost worth having the version info?
This is going to be a major version increment for the PHP side, right?
Silex one, I'm fine with since they provide the constant - why not! Version....yeah it makes sense :/ Hard to be against it.
I have to ask: Any reason why the plugin can't have an Indexer like the Symfony2 plugin, that's makes this unneeded?
Yeah that makes sense. But this is only a pimple limitation. Can other things like routing not be figured out without dumping them? (Not to discredit this structure change)
I'm not sure why nightly is failing. I'd like to think it's unrelated to these changes. Is nightly tested on ~~master~~ main?
Ok this is actually because I have [`overloaded owner`](https://github.com/SeedCompany/cord-api-v3/commit/8b7354c34cc3d15e48d769cc4ea1ae24e6e6cb8b#diff-28c5e3ecfc0796ac7ee01b6a43a33be8d92b069dc70f3630e1cae8900a5e488bR86-R88) which is a link that is no longer an inherited link. It was removed, and then this branch was rebased. So...
This could be similar to what I'm seeing in AWS, where RDS closes idle connections and then edgedb re-establishes them. Every 4 minutes. Though I don't think it's hurting anything...