cadquery icon indicating copy to clipboard operation
cadquery copied to clipboard

Published 20 hours ago • verified publisher icon CadQuery

Update primer.rst - missing show_object(assy)

Open bmsleight opened this issue 1 year ago • 2 comments

Example does not image without show_object(assy)

bmsleight avatar Jan 17 '24 22:01 bmsleight

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff83f99) 94.44% compared to head (e46d42d) 94.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1501   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          28       28           
  Lines        5774     5774           
  Branches     1070     1070           
=======================================
  Hits         5453     5453           
  Misses        194      194           
  Partials      127      127

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 17 '24 22:01 codecov[bot]

@bmsleight None of the other examples in this section include show_object either. I think the code is just meant to be representative, and could be run in any execution environment (CQ-editor, jupyter-cadquery, etc), requiring different show calls.

jmwright avatar Jan 30 '24 16:01 jmwright

Agree with @jmwright - opened https://github.com/CadQuery/CQ-editor/pull/437 to address this for CQ-editor.

adam-urbanczyk avatar May 31 '24 20:05 adam-urbanczyk