wikipron icon indicating copy to clipboard operation
wikipron copied to clipboard

[deu] Split into Swiss German and Germany German. [nep] removes a duplicate from `languages.json`

Open yeonju123 opened this issue 4 years ago • 2 comments

  • [x] Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

ger is split into Swiss German and Germany German. Nep duplicate is removed from languages.json

yeonju123 avatar Dec 15 '20 20:12 yeonju123

Hi Yeonju, this looks good to me.

Can you run the scrape for these languages in your branch to see how this affects the counts? I think you'd follow the instructions here:

https://github.com/kylebgorman/wikipron#repository

then you'd navigate to data/src and run ./scrape --restriction=ger && ./postprocess && ./generate_summary.

kylebgorman avatar Dec 15 '20 20:12 kylebgorman

Ok! I will work on that :)

Yeonju

On Tue, Dec 15, 2020 at 3:23 PM Kyle Gorman [email protected] wrote:

Hi Yeonju, this looks good to me.

Can you run the scrape for these languages in your branch to see how this affects the counts? I think you'd follow the instructions here:

https://github.com/kylebgorman/wikipron#repository

then you'd navigate to data/src and run ./scrape --restriction=ger && ./postprocess && ./generate_summary.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kylebgorman/wikipron/pull/286#issuecomment-745545106, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKPU5EWFSJDFRXFC5IOII3SU7ATJANCNFSM4U45FI4A .

yeonju123 avatar Dec 15 '20 20:12 yeonju123

Just in the interest of getting rid of old bugs, etc., I looked into this and it seems to now be out of date. We have support for gsw, and so there are there are only three words which would be affected by this,and two of them are MWEs. Closing for now.

kylebgorman avatar Feb 21 '24 23:02 kylebgorman