ccextractorfluttergui icon indicating copy to clipboard operation
ccextractorfluttergui copied to clipboard

Migrate bloc to v8

Open rajoriaakash opened this issue 4 years ago • 18 comments

Fixes #9

rajoriaakash avatar Feb 01 '22 17:02 rajoriaakash

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

techno-disaster avatar Feb 01 '22 18:02 techno-disaster

ci fails due to formatting issues, can you fix that?

techno-disaster avatar Feb 02 '22 15:02 techno-disaster

ci fails due to formatting issues, can you fix that?

Hi, i don't have knowledge on ci/cd pipeline but I can surely try 😄.. although it would take some time

rajoriaakash avatar Feb 03 '22 05:02 rajoriaakash

I think flutter analyze should be run before flutter format in workflows as running flutter format first isn't helping in identifying issues.

Although I'm not sure that this commit won't fail :)

rajoriaakash avatar Feb 03 '22 10:02 rajoriaakash

I'll try to fix CI failure

rajoriaakash avatar Feb 03 '22 14:02 rajoriaakash

Could you please run the checks again?

rajoriaakash avatar Feb 03 '22 17:02 rajoriaakash

Looks like formatting still fails could you run

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 

techno-disaster avatar Feb 03 '22 20:02 techno-disaster

Looks like formatting still fails could you run

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 

I sorted the imports

rajoriaakash avatar Feb 04 '22 09:02 rajoriaakash

@Techno-Disaster, please run the tests again :)

rajoriaakash avatar Feb 08 '22 17:02 rajoriaakash

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

rajoriaakash avatar Feb 10 '22 17:02 rajoriaakash

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 
flutter test

should be enough I guess

techno-disaster avatar Feb 11 '22 07:02 techno-disaster

How can I check all the workflows locally without having you run the tests again and again ...might be a dumb question :)

flutter format . 
flutter pub get
flutter pub run import_sorter:main --no-comments 
flutter test

should be enough I guess

thanks !

rajoriaakash avatar Feb 11 '22 17:02 rajoriaakash

I think it should work now :")

rajoriaakash avatar Feb 11 '22 17:02 rajoriaakash

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

@rajoriaakash were you able to look into this?

techno-disaster avatar Feb 12 '22 08:02 techno-disaster

Hi, this LGTM and should mostly work because you also added the sequential transfrom, could you try it out with the other options from bloc_concurrency? Would like to know where this could break and if it has any possible perf improvments

@rajoriaakash were you able to look into this?

I haven't looked into it as of now, will look. This build_linux test is failing due to the package manager ig and is unrelated to my changes.

rajoriaakash avatar Feb 12 '22 16:02 rajoriaakash

I checked all the options from bloc_concurrency and idts it would fail on any of them. Although I think sequential is good to go.

rajoriaakash avatar Feb 15 '22 09:02 rajoriaakash

Yep SGTM, the default was sequential anyway. Thanks for your work! A couple of merge conflicts, do you think you can fix them anytime soon?

Also bloc v9 is a thing but should be easy to migrate afaik.

techno-disaster avatar Feb 20 '23 11:02 techno-disaster