FaceDetector icon indicating copy to clipboard operation
FaceDetector copied to clipboard

Is it better to handle for the case num = int(line.strip()) = 0?

Open edwardnguyen1705 opened this issue 6 years ago • 2 comments

Hi thanks for sharing code. if num = 0 https://github.com/faciallab/FaceDetector/blob/5b588f58884086d005a5ac67bd39a03ce631f8f4/mtcnn/datasets/wider_face.py#L43, for example 10422 0--Parade/0_Parade_Parade_0_452.jpg 10423 0 10424 0 0 0 0 0 0 0 0 0 0 10425 0--Parade/0_Parade_Parade_0_630.jpg then, current_num != num, so flag still be 2. If so, in the next iteration the for line in f: will start from elif flag == 2:, but the current line 0--Parade/0_Parade_Parade_0_630.jpg (flag should be 0)

edwardnguyen1705 avatar Oct 31 '19 14:10 edwardnguyen1705

Is there any case that there is no bbox in a image? If so, I will handle this case.

BrightXiaoHan avatar Nov 28 '19 03:11 BrightXiaoHan

Could you please send me a pull request to handle this problem?

BrightXiaoHan avatar Nov 28 '19 03:11 BrightXiaoHan