capacitor-branch-deep-links icon indicating copy to clipboard operation
capacitor-branch-deep-links copied to clipboard

Add setRequestMetadata, update iOS deployment target and remove web implementation

Open DanProudfoot opened this issue 4 years ago • 2 comments

Hi - shout in advance if all three of these at once is a bit too much, it's just an offshoot of work I've done personally to get this plugin to where I need it. I've changed:

  • Added setRequestMetadata(key, value) to allow integrations like Mixpanel to work correctly.
  • Updated iOS deployment target to 12.0, as Capacitor 3 doesn't run if a Pod is targeting a lower version
  • Completely remove the web implementation as it was causing false positives when running Capacitor.isPluginAvailable("BranchDeepLinks") in the browser environment. As all that the web implementation does is reject on every function call, I feel this is a more elegant solution. I took inspiration from @capacitor/keyboard which works in the same way.

This is my first pull request on anything open source...ever, so please let me know if I need to make tweaks or anything of the sort

DanProudfoot avatar Aug 06 '21 15:08 DanProudfoot

Really need to get this released.

selected-pixel-jameson avatar Sep 16 '21 19:09 selected-pixel-jameson

@DanProudfoot your code helped me, Thanks 🙏

skout90 avatar Dec 21 '22 02:12 skout90