brn icon indicating copy to clipboard operation
brn copied to clipboard

Published 20 hours ago • verified publisher icon Brain-up

EPMLABSBRN-2299 [BE & FrontEnd] Refactoring: merge controllers StudyH…

Open Isink21 opened this issue 3 years ago • 5 comments

…istoryController and StudyHistoryControllerV2 into one class

EPMLABSBRN-XX

Description:

Isink21 avatar Sep 22 '22 10:09 Isink21

gitpod-io[bot] avatar Sep 22 '22 10:09 gitpod-io[bot]

Frontend test coverage: 95.45%

:man_shrugging: Did not change

github-actions[bot] avatar Sep 22 '22 10:09 github-actions[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 22 '22 10:09 sonarqubecloud[bot]

Gradle Unit and Integration Test Results

446 tests  ±0   442 :heavy_check_mark: ±0   58s :stopwatch: -1s 107 suites  - 1       4 :zzz: ±0  107 files    - 1       0 :x: ±0 

Results for commit d78ba878. ± Comparison against base commit 20c40536.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ getHistories should return histories for period of time for user with role user()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ getHistories should return histories for period of time()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ isUserHasStatistics should return true when user has statistics for user with role user()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ isUserHasStatistics should return true when user has statistics()

com.epam.brn.integration.StudyHistoryControllerIT ‑ getHistories should return histories for period of time for user with role user()
com.epam.brn.integration.StudyHistoryControllerIT ‑ getHistories should return histories for period of time()
com.epam.brn.integration.StudyHistoryControllerIT ‑ isUserHasStatistics should return true when user has statistics for user with role user()
com.epam.brn.integration.StudyHistoryControllerIT ‑ isUserHasStatistics should return true when user has statistics()

github-actions[bot] avatar Sep 22 '22 10:09 github-actions[bot]

This task is not only about backend - it is general task about front and back. now this changes will broke the platform

so you need to find all usages of this end-points and change them too

ElenaSpb avatar Sep 23 '22 15:09 ElenaSpb