BoostNote-Legacy

BoostNote-Legacy copied to clipboard

Description

This PR Adds a local git repo as a possible storage option. Two additional options are included (1. Autosync changes with Github. 2. Manually sync note changes to github by clicking a sync button).

When Type: Git Repo is selected, an existing git repository must be chosen. With Auto Sync selected, changes are committed and pushed every 30 seconds with no user action necessary. With Commit Manually selected, a sync icon in the top right appears when the present note is out of sync. Pressing this syncs the note (commits and pushes)

Issue fixed

#2792, #1085

Type of changes

• :white_circle: Bug fix (Change that fixed an issue)
• :white_circle: Breaking change (Change that can cause existing functionality to change)
• :white_circle: Improvement (Change that improves the code. Maybe performance or development improvement)
• :radio_button: Feature (Change that adds new functionality)
• :white_circle: Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• :radio_button: My code follows the project code style
• :white_circle: I have written test for my code and it has been tested
• :radio_button: All existing tests have been passed
• :radio_button: I have attached a screenshot/video to visualize my change if possible

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #2792: Using GitHub integration to use a private repo to sync notes.
• #1085: [Suggestion] Idea for git storage.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

Could you elaborate on this PR by adding a description and providing images of the new functionality? Reviewers shouldn't have to figure out what everything does from just your code.

Could you elaborate on this PR by adding a description and providing images of the new functionality? Reviewers shouldn't have to figure out what everything does from just your code.

Sorry, there was actually a description & screen shots included, but they were commented out for some reason. Please review the updated description.

I think the sync button icon should be updated to match the current style, but I'll let others comment on that

After someone reviews I can write some unit tests before a merge is accepted

How does your code handle when conflicts occur?

While the intention of this PR isn't to add the possibility of having multiple people work on the same notes, I still think people are going to use it that way, so that's why I'm asking.

@Flexo013 it does pull before pushing as a part of the sync process, but it wouldn't work very well currently for the situation you describe:

• The local branch would not be updated until a sync occurs, so the user may be working on something that appears outdated until they try to sync their changes
• If there is a merge conflict then it would need to be resolved manually
• Working on the same note at the same time brings up a few other questions, such as how often the rendered view is updated.

@chrisstpierre @Flexo013 Is there any update on the current progress of merging this into master?

@chrisstpierre can you fix the conflict please? Thank you.

@ZeroX-DG If I get permission to add something to this retrieval request, then I could do that too. Really looking forward to this feature.

@fklement you can take over this PR and continue the work on a different PR if you wish to:) I think the creator of this PR lost interest in this.

@ZeroX-DG All right, then I'll take over the PR and create a new one.

@ZeroX-DG Just so you know I'm still fixing and adding to that PR. Unfortunately I have too much other things to do right now. But when I have more free time, I'm going to tackle this one!