boomerang

boomerang copied to clipboard

When decompiling "Boomerang::get()->alert_decompiling(this);" is called more then once per prog, causing the progress bar to loop around on windows, and potentially other side effects on other platforms.

Decompilation will be ran a few times on the same function, so there's no way it could be changed on the 'engine' side. On the other hand, we might fix it on the gui side, either:

• by changing the progress bar from it's current form to indeterminate progress bar ( just setting min and max to 0s will do the job )
• or holding a std::set of Procs to prevent counting the same Proc multiple times.

What do You think ?

We already associate a status with a proc we can use it to displaya per function status. Is there any reason we use a tree for the decompile when really a call can exist multiple times from multiple callers?

I confess that I never used the boomerang's qt gui . Shame on me :) My guess ? That tree view is a poor-man's call graph view ;)

We should probably have a specific place to get a call graph rather then using the decompile page

Agreed, call graph should be a separate thing, and that tree should be a simple linear list.