setup-racket icon indicating copy to clipboard operation
setup-racket copied to clipboard

[Request] arm32 and arm64 support

Open pmatos opened this issue 5 years ago • 10 comments

What's required here to get arm32 and arm64 support?

pmatos avatar Jul 10 '20 18:07 pmatos

We'd need access to arm installers. If we had those, then all it would take would be to correctly map the URLs when architecture is arm{32,64} here:

https://github.com/Bogdanp/setup-racket/blob/11bb5ff19d1cd718876bc3cf8966a3fbce4354b7/src/common.ts#L32

We could also have a mode where it builds Racket from source but that would be very slow.

Bogdanp avatar Jul 11 '20 05:07 Bogdanp

Thanks - I will try to setup some arm, arm64 snapshots created on the racket/racket side.

pmatos avatar Jul 15 '20 11:07 pmatos

are you missing arm64 snapshots for this to work on arm64?

pmatos avatar Nov 27 '20 11:11 pmatos

Yup! I've added support for the arch and guessed at what the URLs will end up being, but there don't seem to be installers for arm64 on the Utah snapshot server yet so arm64 won't work yet.

Bogdanp avatar Nov 27 '20 11:11 Bogdanp

I will add snapshots for these in the next couple of days. I will keep you up-to-date.

pmatos avatar Nov 27 '20 12:11 pmatos

any traction here? I guess the snapshots should be available now.

jessealama avatar Jan 03 '21 10:01 jessealama

@jessealama it looks like only 32bit arm snapshots are available still: https://www.cs.utah.edu/plt/snapshots/

It looks like there are now snapshots for the M1 chips, though, so I'll have to add support for those as well.

Bogdanp avatar Jan 03 '21 11:01 Bogdanp

Installers for Apple Silicon Macs are supported as of https://github.com/Bogdanp/setup-racket/pull/20/commits/94699d415b27bab4501b62f42f74b4eb8153d769 . GH Actions don't yet support Apple Silicon, though, so they aren't tested.

Bogdanp avatar Jan 13 '21 10:01 Bogdanp

I'm try to use

      - uses: Bogdanp/[email protected]
        with:
          architecture: aarch64

get:

invalid arch 'aarch64'

what can I do here? Should I adjust runs-on: ubuntu-latest line?

dannypsnl avatar Dec 08 '21 08:12 dannypsnl

@dannypsnl I've just pushed a fix to the master branch for that problem. However, there aren't any arm64 linux installers on the Utah snapshot server yet so even with that fix in place, this still won't work. You can only currently use either arm32 on Linux or aarch64 on macOS. However, you need to bring your own GH Actions runners, because GitHub doesn't yet have arm runners.

Bogdanp avatar Dec 08 '21 09:12 Bogdanp