lean-monitor-2 icon indicating copy to clipboard operation
lean-monitor-2 copied to clipboard

Adding support for new BaseSeries

Open jsboige opened this issue 2 years ago • 3 comments

Hi, I have been trying to get your app to work with latest Lean codebase.

After those changes, the app starts normally. I use a file session with the result of the default session/algorithm used without touching the launcher's config upon cloning Lean.

However, timespan axis starts in 1900. I tried to figure out how to change that and couldn't find. I suppose you might know better.

Also, I tried to update Avalonia and other packages to the latest version. I ended up giving up but I believe I did most of the work. I've put those additional updates in a distinct branch. I'll do another pull request for you to see, but it's not ready yet, with a theming issue I believe.

jsboige avatar Oct 21 '23 01:10 jsboige

@jsboige thanks a lot for your contribution, looks good to me. Would you be able to post the result file you used for testing here? U haven't used QC fow a while now, but happy to investiagte the issue you faced

BobLd avatar Oct 21 '23 11:10 BobLd

Thanks for your message. Here are the files for the sample session running Lean's launcher after a fresh build, without touching anything: Apparently it uses Candles, thus my work to accomodate that in this PR, though I only projected into InstantChartPoints for now, since going further would require significantly more work I believe (translating from Newtonsoft to System.Test.Json did already take some time) SampleSession.zip

jsboige avatar Oct 21 '23 11:10 jsboige

Hi @BobLd, did you get the opportunity to have a look at the timeline initialization issue? I'll be happy to do some more tests and PRs with my students, as I'm teaching a course with Lean in c#. I feel your tool is an important extension for local experiments, and I'm a bit worried not having that option as they start getting familiar with the launcher. I've never done Avalonia though, so I'll need your support on that part. Thanks in advance !

jsboige avatar Oct 24 '23 12:10 jsboige

Thanks for merging that important fix. At least that makes the UI partially usable. Now there is that other PR with unfinished half-way attempt to migrate to latest Avalonia. I'll try to help again at some point.

jsboigeECE avatar Feb 11 '25 11:02 jsboigeECE