BitFunnel icon indicating copy to clipboard operation
BitFunnel copied to clipboard

Changing code style from Hungarian to Google

Open yingfeng opened this issue 9 years ago • 1 comments

I know that within Microsoft, Hungarian code style has been used for a long time, however, most open source C++ projects are choosing Google or ANSI code style, what about adjusting the code to meet most guys' taste? ...

yingfeng avatar Oct 28 '16 01:10 yingfeng

Thanks for the question, @yingfeng. Actually BitFunnel's style guide is a very, very lightly modified version of the Google C++ style guide. The only Hungarian-esque exception I know of is our practice of prefixing member variable names with m_. This is leftover from the style of the larger eng group that BitFunnel was born in, and though regrettable, I think it is unlikely to change at this point.

Other than that, I can't recall any occasions where we've opted for the Hungarian style. Do you have a particular example you have found irksome?

hausdorff avatar Oct 28 '16 23:10 hausdorff