Cve-api icon indicating copy to clipboard operation
Cve-api copied to clipboard

Make it easier to change ports

Open Beyarz opened this issue 6 years ago • 5 comments

At the moment, if I would like to to change the port for production, I'd have to manually change the number on a few places.

This can easily be refactored to one single dependent file.

Beyarz avatar Feb 16 '20 14:02 Beyarz

Is this still an issue? Or do the .env files make this a non-issue?

devmaximilian avatar Feb 16 '20 17:02 devmaximilian

Is this still an issue? Or do the .env files make this a non-issue?

The issue here is, that not every file follows the .env direction. For example, the Dockerfile relies on a static port I've entered manually.

Beyarz avatar Feb 16 '20 17:02 Beyarz

@devmaximilian Do you think we could make the Dockerfile parse the data we've entered on production.env?

Beyarz avatar Feb 16 '20 17:02 Beyarz

@Beyarz Yes, that should be possible. I think we can use ENV to accomplish this.

devmaximilian avatar Feb 16 '20 18:02 devmaximilian

@Beyarz After some further investigation, I can say that what I previously suggested won't be possible. I'd suggest that we use environment variables passed to the production image (when it is run) to set the values for the healthcheck and application.

devmaximilian avatar Feb 17 '20 19:02 devmaximilian