Benjamin Dobell

Results 145 comments of Benjamin Dobell

Seems as ace-diff looks first for `Range` on `ace` (as provided to the `AceDiff` constructor), you can work around this issue with: ```js import ace from 'brace' ace.Range = ace.acequire("ace/range").Range...

I should probably note that `grunt-template-jasmine-requirejs` is no longer maintained (last update around 3 years ago), so I've switched to a fork that is maintained.

Hmm, so after I go claiming the positioning is correct in this pull request it fails a positioning test. Whoops. Investigating...

There we go! All sorted. Basically we can't reliably use `getBoundingClientRect` on the container element as it returns the _rendered_ bounding box of the container's current content, _if_ the container...

@suhmantha1 @levib I think you'll want to follow up with @zimmi88 as to why this wasn't merged (or closed). It conflicts now, but didn't at the time. I've been using...

I've just fixed a bug with the auto-scroll functionality and rebased on master so that this will merge cleanly. The tests for this pull request (and pretty much every other...

TravisCi doesn't ever ask you for your Github password. It logs in to your Github account using tokens. However, there is a related issue that travis-ci.com requires _way_ more permission...

There's currently no way to document (add descriptions to) parameters in overloads. That's already a problem, but will be a much larger issue with this proposed change. Will need to...

You've got union and intersection types around the wrong way; currently only union types are supported. There are no intersection types. That said, with the specific example you've given, an...

https://www.typescriptlang.org/docs/handbook/unions-and-intersections.html#intersection-types