meson-build icon indicating copy to clipboard operation
meson-build copied to clipboard

Ninja could not be found after installing

Open pwnorbitals opened this issue 5 years ago • 4 comments

Here is the full error log :

Run BSFishy/[email protected] with: action: build directory: build meson-version: 0.53.2 ninja-version: 1.9.0.post1 gcovr-version: 4.2 Installing Ninja version 1.9.0.post1 /usr/bin/python -m pip install ninja==1.9.0.post1 Collecting ninja==1.9.0.post1 Downloading https://files.pythonhosted.org/packages/6f/11/536b532fe7613de0376862ef20b8b2850033ed5675a8237bfb1a53ef6131/ninja-1.9.0.post1-py2-none-manylinux1_x86_64.whl (98kB) Installing collected packages: ninja Successfully installed ninja-1.9.0.post1 ##[error]Ninja could not be found after installing

This is a simple default gh actions that runs on ubuntu-latest

pwnorbitals avatar Jul 31 '20 07:07 pwnorbitals

Seems like running setup-python first fixes this.

https://github.com/marketplace/actions/setup-python

BrknRobot avatar Sep 20 '20 16:09 BrknRobot

Can this be automated in the action witout too much effort ? I’m wondering what the root cause may be, though

pwnorbitals avatar Sep 20 '20 21:09 pwnorbitals

Most likely the directory pip is installing to isn't in $PATH, and setup-python is adding it. Probably, this action should just depend on setup-python rather than doing it's own python setup.

BrknRobot avatar Sep 20 '20 22:09 BrknRobot

Apologies I took this long to see this. Yes, make sure you use the setup-python action. It sets up Python correctly and is what this action was tested with. I looked into integrating the setup-python action with this one, and unfortunately it doesn't seem plausible. The way that actions are invoked doesn't give them an easy way to communicate, and the way that setup-python works is non-standard. I would recommend just using that action before this one, as that is most likely to work.

Hope this helped!

BSFishy avatar Sep 21 '20 14:09 BSFishy