BHoM_Engine icon indicating copy to clipboard operation
BHoM_Engine copied to clipboard

Facade_Engine: Update Methods to Handle UValueCavity Fragment

Open vgreen-BH opened this issue 3 years ago • 7 comments

Issues addressed by this PR

Closes #2951

  • Updated UValueOpeningAW method to handle construction fragment UValueCavity
  • Updated UValuePanelAW method to handle construction fragment UValueCavity

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Engine/Facade_Engine/BHoM%20PR%20Test%20Files/Facade_Engine-Cavity%20Insulation%20Test%20File.gh?csf=1&web=1&e=H9metl

vgreen-BH avatar Nov 29 '22 01:11 vgreen-BH

@BHoMBot check compliance

enarhi avatar Nov 29 '22 23:11 enarhi

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

bhombot-ci[bot] avatar Nov 29 '22 23:11 bhombot-ci[bot]

@BHoMBot check required

enarhi avatar Nov 30 '22 00:11 enarhi

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

bhombot-ci[bot] avatar Nov 30 '22 00:11 bhombot-ci[bot]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Nov 30 '22 00:11 bhombot-ci[bot]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Nov 30 '22 00:11 bhombot-ci[bot]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Nov 30 '22 00:11 bhombot-ci[bot]

@BHoMBot check compliance

enarhi avatar Dec 02 '22 20:12 enarhi

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

bhombot-ci[bot] avatar Dec 02 '22 20:12 bhombot-ci[bot]

@BHoMBot check unit-tests

enarhi avatar Dec 02 '22 20:12 enarhi

@enarhi to confirm, the following actions are now queued:

  • check unit-tests

There are 7 requests in the queue ahead of you.

bhombot-ci[bot] avatar Dec 02 '22 20:12 bhombot-ci[bot]

@BHoMBot check required

enarhi avatar Dec 02 '22 20:12 enarhi

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 4 requests in the queue ahead of you.

bhombot-ci[bot] avatar Dec 02 '22 20:12 bhombot-ci[bot]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Dec 02 '22 20:12 bhombot-ci[bot]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Dec 02 '22 20:12 bhombot-ci[bot]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Dec 02 '22 20:12 bhombot-ci[bot]

@BHoMBot check ready-to-merge

enarhi avatar Dec 02 '22 20:12 enarhi

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

bhombot-ci[bot] avatar Dec 02 '22 20:12 bhombot-ci[bot]