ember-modal-service icon indicating copy to clipboard operation
ember-modal-service copied to clipboard

Glimmer components support

Open SergeAstapov opened this issue 6 years ago • 3 comments

As Octane edition is around the corner it seem good time to get support (or at least define/discuss the plan if it's not defined yet) for Glimmer Components.

SergeAstapov avatar Sep 26 '19 01:09 SergeAstapov

<ModalContainer /> component seem to be pretty simple to convert as not much going on in the component class.

<Modal /> might be trickier, because user defined components should extend from base component provided by the addon, however with Octane lots of things should be moved to template.

Potentially, addon may provide base component class + some component that need to be placed in each modal template.

SergeAstapov avatar Sep 26 '19 01:09 SergeAstapov

Sorry for the delay, more than 2 years have passed since opened.

Still working on it and should be tested in a real app before merged but it seems to work well: https://github.com/BBVAEngineering/ember-modal-service/pull/153

josex2r avatar Dec 01 '21 08:12 josex2r

@josex2r Is there any news on this, seems almost another year has passed 😉

lougreenwood avatar Nov 29 '22 10:11 lougreenwood