azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

[Confidential Ledger] Migrate to test-proxy

Open lynshi opened this issue 3 years ago • 1 comments

Description

Migrate tests for Confidential Ledger to the new test-proxy framework. New recordings have been added, and I also tested with AZURE_SKIP_LIVE_RECORDING=true to ensure live tests that don't go through the proxy work.

This PR currently includes some changes to infrastructure/tooling required to support Confidential Ledger scenarios (e.g. to use a newer test proxy version), but they may be superseded by changes to the main repo. Note the CI will reject these changes under eng/common.

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

lynshi avatar Aug 12 '22 21:08 lynshi

API change check

API changes are not detected in this pull request.

azure-sdk avatar Aug 12 '22 21:08 azure-sdk

I have no earthly idea why an eng/common change is showing up in this PR. Super frustrating.

scbedd avatar Aug 15 '22 22:08 scbedd

I have no earthly idea why an eng/common change is showing up in this PR. Super frustrating.

Fixed this, sorry! (The change was file mode 100644 -> 100755 because I chmod +x to run apply-dev-cert.sh - GitHub diff shows no file content changes, and the mode change is displayed inline with the filename)

lynshi avatar Aug 15 '22 23:08 lynshi

@lynshi Can you put it back? I've overwritten the file locally with the one from main, but it still shows that change. We do not allow eng/common changes from anything other than a specific workflow.

scbedd avatar Aug 16 '22 17:08 scbedd

/azp run python - confidentialledger - tests

lynshi avatar Aug 16 '22 21:08 lynshi

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 16 '22 21:08 azure-pipelines[bot]

/azp run python - confidentialledger - tests

scbedd avatar Aug 16 '22 22:08 scbedd

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 16 '22 22:08 azure-pipelines[bot]