azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Updates to enable live testing in sovereign clouds for multiple services

Open zedy-wj opened this issue 4 years ago • 7 comments

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Using this RR to trace and fix issues we encounter in the tests. Will close it once we finish all the tests and send PR per services.

Updated list: Text analytics Storage account Form recognizer

zedy-wj avatar May 28 '21 02:05 zedy-wj

Thank you for your contribution @zedy-wj! We will review the pull request and get back to you soon.

ghost avatar May 28 '21 02:05 ghost

Looks good from a config standpoint. @jsquire can you weigh in again and/or route for review on the code changes?

benbp avatar Jun 04 '21 19:06 benbp

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: /check-enforcer evaluate Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command: /check-enforcer override Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment: /azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

check-enforcer[bot] avatar Jun 08 '21 03:06 check-enforcer[bot]

Hi, @benbp! Shall we add Preview in SupportedClouds, I remember that you asked me to delete it in other services before. Why do we do that?

zedy-wj avatar Jul 05 '21 07:07 zedy-wj

@zedy-wj Preview is added as a pre-defined cloud only for services that need to use a separate subscription with additional ARM feature flags enabled. Originally, the tests-weekly behavior was set up to include all defined CloudConfig clouds by default. Typing this out, I'm realizing it would be better for us to change the default set of clouds for weekly in the archetype-sdk-tests.yml template, rather than requiring you to specify them in tests.yml. For now though, Preview should be excluded since there's no added value in testing it along with Public.

https://github.com/Azure/azure-sdk-tools/issues/1781

benbp avatar Jul 07 '21 00:07 benbp

Hi @zedy-wj. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

ghost avatar Jan 28 '22 10:01 ghost

API change check

API changes are not detected in this pull request.

azure-sdk avatar Sep 22 '22 07:09 azure-sdk