azure-sdk-for-js
azure-sdk-for-js copied to clipboard
[loadtestservice] Release Data Plane RLC
Packages impacted by this PR
loadtestservice
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Rest Level Client
Are there test cases added in this PR? (If not, why?)
No, I am adding the test cases parallely.
Command used to generate this PR:**(Applicable only to SDK release request PRs)
autorest command to generate ts RLC. https://github.com/Azure/azure-sdk-for-js/blob/502d7dca7437a43e9640e4b1e4a90b5bba73a3bd/documentation/RLC-quickstart.md
Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
- [ ] Added a changelog (if necessary)
This pull request is protected by Check Enforcer.
What is Check Enforcer?
Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.
Why am I getting this message?
You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.
What should I do now?
If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).
What if I am onboarding a new service?
Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci
@mrinal2601 did we get approval from the arch board for the package name? What is the name of this package in other languages?
@mrinal2601 did we get approval from the arch board for the package name? What is the name of this package in other languages?
Hi, the package name is "loadtesting" in other languages, thanks for pointing this out, I am changing this package name to "@azure-rest/loadtesting".
@mrinal2601 did we get approval from the arch board for the package name? What is the name of this package in other languages?
Hi, the package name is "loadtesting" in other languages, thanks for pointing this out, I am changing this package name to "@azure-rest/loadtesting".
I spoke with @bterlson and the JS team and we'd like to recommend @azure-rest/load-testing
API change check
APIView has identified API level changes in this PR and created following API reviews.
There are Long Running Operations that are not marked as such in swagger, this causes the generator not to generate the LRO helpers. @mrinal2601 can you please file an issue to track updating the samples once the swagger is updated and re-generate the client?
https://dev.azure.com/devdiv/OnlineServices/_workitems/edit/1646864 - created issue here.
@joheredi I will merge the PR first. Let me know if you have other comments. Also, can you check with @xirzec about the release cycle ?