azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

Nio default filesystem

Open jaschrep-msft opened this issue 3 years ago • 4 comments

jaschrep-msft avatar Aug 31 '22 19:08 jaschrep-msft

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-common azure-storage-blob-nio

azure-sdk avatar Sep 02 '22 19:09 azure-sdk

Don't forget a changelog entry

rickle-msft avatar Sep 06 '22 22:09 rickle-msft

Looks like it's perhaps missing a test that defaults are loaded if values are missing from the config map? And also that it will auto load a filesystem if one isn't present?

rickle-msft avatar Sep 06 '22 22:09 rickle-msft

Looks like it's perhaps missing a test that defaults are loaded if values are missing from the config map? And also that it will auto load a filesystem if one isn't present?

Yep! Nearly there. Been sorting out build issues before we get to a default environment.

jaschrep-msft avatar Sep 07 '22 14:09 jaschrep-msft

/azp run java - storage - ci

jaschrep-msft avatar Nov 10 '22 15:11 jaschrep-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 10 '22 15:11 azure-pipelines[bot]

@jaschrep-msft What is the status on this PR?

JonathanGiles avatar Dec 08 '22 20:12 JonathanGiles

@JonathanGiles priorities have cut in line.

It has been some time but I believe the majority of this work is finished and it's a matter of testing that an environmental configuration is actually being read.

jaschrep-msft avatar Dec 09 '22 19:12 jaschrep-msft

Hi @jaschrep-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

ghost avatar Feb 10 '23 10:02 ghost

Hi @jaschrep-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

ghost avatar Feb 17 '23 11:02 ghost