azure-sdk-for-c

azure-sdk-for-c copied to clipboard

Several CMakeLists.txt files make use of add_link_options() which only got added in CMake 3.13 so cmake_minimum_required should likely be bumped to 3.13, and maybe worth double-checking there are no other dependencies toward 3.13+

https://cmake.org/cmake/help/v3.13/release/3.13.html#commands

@barcharcraz - thoughts? Do we lose anything from bumping it? Its 3.10 atm.

https://github.com/Azure/azure-sdk-for-c/blob/a694dabf75e09405bfcb160d82f353386ed7fcf0/CMakeLists.txt#L4

We recently started using add_link_options() anyway (cc @danieljurek, as part of https://github.com/Azure/azure-sdk-for-c/pull/956) https://github.com/Azure/azure-sdk-for-c/blob/356e4ddf9f4e2ac2a74f736b6c9e4de7e3cd19fb/sdk/tests/iot/common/CMakeLists.txt#L14

cc @vhvb1989, @RickWinter

It was originally 3.10 because Ubuntu 18.04 apt gets are max'd at that version. People on 18.04 would have to install from source. But if we use features in 3.13 then we should probably bump

@danieljurek - this is related to https://github.com/Azure/azure-sdk-for-c/issues/1170 which is assigned to you. Depending on the fix for add_link_options, this issue might just need to be closed without any other action.

This resulted in 2 additional issues:

• https://github.com/Azure/azure-sdk-for-c/issues/1170 -- Removes use of add_link_options in cases where the cmake version is <= 3.13. This mitigates the problem of building.
• https://github.com/Azure/azure-sdk-for-c/issues/1169 -- Get CMake 3.10 running on agents (later versions are installed by default). This is estimated at 5 complexity because there will be some refactor work to build with containers in the cases of linux and windows and installation/path modification in the case of macos.

@ahsonkhan Will this be ready for the March cycle?

I haven't looked at this issue for quite a while, so its unlikely this will be ready, unless we want to prioritize it. Let me know and I can take a quick look and provide an estimate.

This issue, similar to https://github.com/Azure/azure-sdk-for-c/issues/1169#issuecomment-687373077 could be like peeling an onion. We fixed the add_link_options issue, but there might be more things that are not compatible with cmake 3.10.

Deferring to future for now until we see any customer concerns related to this, to motivate re-investigating further.

Hi @kartben, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.