azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Pdaryani recoveryservices 2024 04 30 preview

Open pdaryani010 opened this issue 1 year ago • 8 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

pdaryani010 avatar Apr 22 '24 11:04 pdaryani010

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 8 Warnings warning [Detail]
Compared specs (v0.10.8) new version base version
registeredidentities.json 2024-04-30-preview(bc79699) 2024-04-01(main)
registeredidentities.json 2024-04-30-preview(bc79699) 2022-09-30-preview(main)
replicationusages.json 2024-04-30-preview(bc79699) 2024-04-01(main)
replicationusages.json 2024-04-30-preview(bc79699) 2022-09-30-preview(main)
vaults.json 2024-04-30-preview(bc79699) 2024-04-01(main)
vaults.json 2024-04-30-preview(bc79699) 2022-09-30-preview(main)
vaultusages.json 2024-04-30-preview(bc79699) 2024-04-01(main)
vaultusages.json 2024-04-30-preview(bc79699) 2022-09-30-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
:warning: 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.RecoveryServices/preview/2024-04-30-preview/vaults.json#L529:11
:warning: 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.RecoveryServices/preview/2024-04-30-preview/vaults.json#L537:11
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.RecoveryServices/preview/2024-04-30-preview/vaults.json#L542:13
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/vaults.json#L523:13
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v3/types.json#L305:9
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/vaults.json#L2019:9
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v3/types.json#L280:11
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/vaults.json#L2044:11
:warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.RecoveryServices/preview/2024-04-30-preview/vaults.json#L1830:13
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/vaults.json#L1678:13
:warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.RecoveryServices/preview/2024-04-30-preview/vaults.json#L1844:13
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/vaults.json#L1692:13
:warning: 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.RecoveryServices/preview/2024-04-30-preview/vaults.json#L505:7
Old: Microsoft.RecoveryServices/preview/2022-09-30-preview/vaults.json#L494:7
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-04 package-preview-2024-04(bc79699) default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName} is missing.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L20
ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L20
PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/certificates/{certificateName}'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L21
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L21
ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L21
SubscriptionsAndResourceGroupCasing The path segment Subscriptions should be subscriptions.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L21
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'VaultCertificates_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L22
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L22
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L64
PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/registeredIdentities/{identityName}'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L80
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L80
ResourceNameRestriction The resource name parameter 'identityName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L80
SubscriptionsAndResourceGroupCasing The path segment Subscriptions should be subscriptions.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L80
DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L81
DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L108
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L108
NestedResourcesMustHaveListOperation The nested resource 'VaultCertificateResponse' does not have list operation, please add it.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L300
XmsParameterLocation The parameter 'SubscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L327
XmsParameterLocation The parameter 'ApiVersion' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json#L350
PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/replicationUsages'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L21
ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L21
SubscriptionsAndResourceGroupCasing The path segment Subscriptions should be subscriptions.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L21
RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L45
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L48
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L70
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L74
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L78
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L88
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L92
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.RecoveryServices/preview/2024-04-30-preview/replicationusages.json#L96
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from bbb89c750a1d76de92239ff0fcbbb9150ed98eae. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.RecoveryServices [Preview SDK Changes] Breaking Change Detected
    • Azure.ResourceManager.RecoveryServices.1.2.0-alpha.20240509.1.nupkg
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation<Azure.ResourceManager.RecoveryServices.RecoveryServicesVaultResource> Azure.ResourceManager.RecoveryServices.RecoveryServicesVaultResource.Update(Azure.WaitUntil, Azure.ResourceManager.RecoveryServices.Models.RecoveryServicesVaultPatch, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.RecoveryServices.RecoveryServicesVaultResource>> Azure.ResourceManager.RecoveryServices.RecoveryServicesVaultResource.UpdateAsync(Azure.WaitUntil, Azure.ResourceManager.RecoveryServices.Models.RecoveryServicesVaultPatch, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.RecoveryServices.Models.VaultPropertiesRedundancySettings Azure.ResourceManager.RecoveryServices.Models.ArmRecoveryServicesModelFactory.VaultPropertiesRedundancySettings(System.Nullable<Azure.ResourceManager.RecoveryServices.Models.StandardTierStorageRedundancy>, System.Nullable<Azure.ResourceManager.RecoveryServices.Models.CrossRegionRestore>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.RecoveryServices.Models.RecoveryServicesAlertsState> Azure.ResourceManager.RecoveryServices.Models.VaultMonitoringSettings.AzureMonitorAlertAlertsForAllJobFailures.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.RecoveryServices.Models.VaultMonitoringSettings.AzureMonitorAlertAlertsForAllJobFailures.set(System.Nullable<Azure.ResourceManager.RecoveryServices.Models.RecoveryServicesAlertsState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.RecoveryServices.Models.RecoveryServicesAlertsState> Azure.ResourceManager.RecoveryServices.Models.VaultMonitoringSettings.ClassicAlertAlertsForCriticalOperations.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.RecoveryServices.Models.VaultMonitoringSettings.ClassicAlertAlertsForCriticalOperations.set(System.Nullable<Azure.ResourceManager.RecoveryServices.Models.RecoveryServicesAlertsState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.RecoveryServices/Debug/netstandard2.0/Azure.ResourceManager.RecoveryServices.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/recoveryservices/Azure.ResourceManager.RecoveryServices/src/Azure.ResourceManager.RecoveryServices.csproj::TargetFramework=netstandard2.0]
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from bbb89c750a1d76de92239ff0fcbbb9150ed98eae. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-recoveryservices [Preview SDK Changes]
    • azure_mgmt_recoveryservices-1.0.0b1-py3-none-any.whl
    • azure-mgmt-recoveryservices-1.0.0b1.zip
    info	[Changelog]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from bbb89c750a1d76de92239ff0fcbbb9150ed98eae. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-recoveryservices [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-recoveryservices-1.3.0-beta.1-sources.jar
    • azure-resourcemanager-recoveryservices-1.3.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from bbb89c750a1d76de92239ff0fcbbb9150ed98eae. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/recoveryservices/armrecoveryservices [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Operation `*VaultsClient.Delete` has been changed to LRO, use `*VaultsClient.BeginDelete` instead.
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `StandardTierStorageRedundancyInvalid` added to enum type `StandardTierStorageRedundancy`
    info	[Changelog] - New enum type `BCDRSecurityLevel` with values `BCDRSecurityLevelExcellent`, `BCDRSecurityLevelFair`, `BCDRSecurityLevelGood`, `BCDRSecurityLevelPoor`
    info	[Changelog] - New enum type `EnhancedSecurityState` with values `EnhancedSecurityStateAlwaysON`, `EnhancedSecurityStateDisabled`, `EnhancedSecurityStateEnabled`, `EnhancedSecurityStateInvalid`
    info	[Changelog] - New struct `ErrorDetail`
    info	[Changelog] - New struct `ErrorResponse`
    info	[Changelog] - New field `AlertsForAllFailoverIssues`, `AlertsForAllReplicationIssues` in struct `AzureMonitorAlertSettings`
    info	[Changelog] - New field `EmailNotificationsForSiteRecovery` in struct `ClassicAlertSettings`
    info	[Changelog] - New field `EnhancedSecurityState` in struct `SoftDeleteSettings`
    info	[Changelog] - New field `BcdrSecurityLevel`, `ResourceGuardOperationRequests` in struct `VaultProperties`
    info	[Changelog] - New field `XMSAuthorizationAuxiliary` in struct `VaultsClientBeginCreateOrUpdateOptions`
    info	[Changelog] - New field `XMSAuthorizationAuxiliary` in struct `VaultsClientBeginUpdateOptions`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 21 additive change(s).
    Present SDK breaking changes suppressions
    Operation `*VaultsClient.Delete` has been changed to LRO, use `*VaultsClient.BeginDelete` instead.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from bbb89c750a1d76de92239ff0fcbbb9150ed98eae. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-recoveryservices [Preview SDK Changes] Breaking Change Detected
    • azure-arm-recoveryservices-6.0.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation Vaults.beginDelete
    info	[Changelog]   - Added operation Vaults.beginDeleteAndWait
    info	[Changelog]   - Added Interface ErrorDetail
    info	[Changelog]   - Added Interface ErrorResponse
    info	[Changelog]   - Added Interface VaultsDeleteHeaders
    info	[Changelog]   - Added Type Alias BcdrSecurityLevel
    info	[Changelog]   - Added Type Alias EnhancedSecurityState
    info	[Changelog]   - Added Type Alias VaultsDeleteResponse
    info	[Changelog]   - Interface AzureMonitorAlertSettings has a new optional parameter alertsForAllFailoverIssues
    info	[Changelog]   - Interface AzureMonitorAlertSettings has a new optional parameter alertsForAllReplicationIssues
    info	[Changelog]   - Interface ClassicAlertSettings has a new optional parameter emailNotificationsForSiteRecovery
    info	[Changelog]   - Interface SoftDeleteSettings has a new optional parameter enhancedSecurityState
    info	[Changelog]   - Interface VaultProperties has a new optional parameter bcdrSecurityLevel
    info	[Changelog]   - Interface VaultProperties has a new optional parameter resourceGuardOperationRequests
    info	[Changelog]   - Interface VaultsCreateOrUpdateOptionalParams has a new optional parameter xMsAuthorizationAuxiliary
    info	[Changelog]   - Interface VaultsDeleteOptionalParams has a new optional parameter resumeFrom
    info	[Changelog]   - Interface VaultsDeleteOptionalParams has a new optional parameter updateIntervalInMs
    info	[Changelog]   - Interface VaultsUpdateOptionalParams has a new optional parameter xMsAuthorizationAuxiliary
    info	[Changelog]   - Added Enum KnownBcdrSecurityLevel
    info	[Changelog]   - Added Enum KnownEnhancedSecurityState
    info	[Changelog]   - Enum KnownStandardTierStorageRedundancy has a new value Invalid
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Removed operation Vaults.delete
    Present SDK breaking changes suppressions
    Removed operation Vaults.delete
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from bbb89c750a1d76de92239ff0fcbbb9150ed98eae. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from bbb89c750a1d76de92239ff0fcbbb9150ed98eae. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.recoveryservices.DefaultTag [Preview SDK Changes]
    • Az.RecoveryServices.0.1.0.nupkg
Posted by Swagger Pipeline | How to fix these errors?

please update "PR review workflow diagram"

ramoka178 avatar Apr 23 '24 22:04 ramoka178

Are there any changes at all in this new api version ? I dont see any. I just see same files as previous api-version being copied to this new api version. Could you confirm ?

ramoka178 avatar Apr 26 '24 23:04 ramoka178

This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Learn more at aka.ms/azsdk/pr-arm-review.

yes its just new version, no changes.

pdaryani010 avatar Apr 27 '24 03:04 pdaryani010

yes its just new version, no changes.

We probably could have signed it off sooner if we realized, sorry for the delay!

TimLovellSmith avatar May 03 '24 01:05 TimLovellSmith

TypeSpec Requirement is randomly failing, @AzureRestAPISpecReview pls suggest how to get the PR merged in this case. It was signed off long back.

Checking specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/preview/2024-04-30-preview/registeredidentities.json npm ERR! code E404 npm ERR! 404 Not Found - GET https://registry.npmjs.org/get-suppressions - Not found npm ERR! 404 npm ERR! 404 'get-suppressions@*' is not in this registry.

pdaryani010 avatar May 07 '24 14:05 pdaryani010

/azp run TypeSpec Requirement

mikeharder avatar May 08 '24 03:05 mikeharder

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 08 '24 03:05 azure-pipelines[bot]

/azp run

mikeharder avatar May 08 '24 03:05 mikeharder

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar May 08 '24 03:05 azure-pipelines[bot]

/pr RequestMerge

pdaryani010 avatar May 09 '24 05:05 pdaryani010