azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

`OperationalInsights`@2019-09-01: add status code `201` for `QueryPacks_CreateOrUpdate`

Open wuxu92 opened this issue 1 year ago • 7 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Other, please clarify:
    • fixes #19603

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

wuxu92 avatar Jan 25 '24 06:01 wuxu92

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
QueryPacks.json 2019-09-01(d49a95b) 2019-09-01(main)
Rule Message
1011 - AddingResponseCode The new version adds a response code '201'.
New: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L272:11
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2023-09 package-2023-09(d49a95b) package-2023-09(main)
package-2022-02 package-2022-02(d49a95b) package-2022-02(main)
package-2022-10 package-2022-10(d49a95b) package-2022-10(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L73
EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L73
EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L73
PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/queryPacks has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L73
PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/queryPacks has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L73
PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/queryPacks has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L73
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L111
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L111
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L111
ResourceNameRestriction The resource name parameter 'queryPackName' should be defined with a 'pattern' restriction.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L158
ResourceNameRestriction The resource name parameter 'queryPackName' should be defined with a 'pattern' restriction.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L158
ResourceNameRestriction The resource name parameter 'queryPackName' should be defined with a 'pattern' restriction.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L158
AllTrackedResourcesMustHaveDelete The resource LogAnalyticsQueryPack does not have a corresponding delete operation.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L390
AllTrackedResourcesMustHaveDelete The resource LogAnalyticsQueryPack does not have a corresponding delete operation.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L390
AllTrackedResourcesMustHaveDelete The resource LogAnalyticsQueryPack does not have a corresponding delete operation.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L390
TrackedResourcePatchOperation Tracked resource 'LogAnalyticsQueryPack' must have patch operation that at least supports the update of tags.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L390
TrackedResourcePatchOperation Tracked resource 'LogAnalyticsQueryPack' must have patch operation that at least supports the update of tags.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L390
TrackedResourcePatchOperation Tracked resource 'LogAnalyticsQueryPack' must have patch operation that at least supports the update of tags.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L390
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L43
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L43
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L43
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L46
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L46
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L46
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L53
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L53
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L53
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L79
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L79
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L79
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
:warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/operationalinsights/resource-manager/readme.md
tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2023-09
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]
Rule Message
RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 201 for operation QueryPacks_CreateOrUpdate were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
Url: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L272:18
ExampleUrl: stable/2019-09-01/examples/QueryPacksCreate.json#L12:16
RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE Following response status codes 201 for operation QueryPacks_CreateOrUpdate were present in the swagger spec, however they were not present in x-ms-examples. Please provide them.
Url: Microsoft.OperationalInsights/stable/2019-09-01/QueryPacks.json#L272:18
ExampleUrl: stable/2019-09-01/examples/QueryPacksUpdate.json#L15:16
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9c31b23fb084430286c75be5fe926b3fea6cd89e. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.OperationalInsights [Preview SDK Changes]
    • Azure.ResourceManager.OperationalInsights.1.3.0-alpha.20240514.1.nupkg
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9c31b23fb084430286c75be5fe926b3fea6cd89e. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/operationalinsights/armoperationalinsights [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `Cluster.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    info	[Changelog] - Type of `ClusterPatch.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    info	[Changelog] - Operation `*TablesClient.Update` has been changed to LRO, use `*TablesClient.BeginUpdate` instead.
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `CapacityFiftyThousand`, `CapacityFourHundred`, `CapacityOneHundred`, `CapacityTenThousand`, `CapacityThreeHundred`, `CapacityTwentyFiveThousand`, `CapacityTwoHundred` added to enum type `Capacity`
    info	[Changelog] - New value `CapacityReservationLevelFiftyThousand`, `CapacityReservationLevelTenThousand`, `CapacityReservationLevelTwentyFiveThousand` added to enum type `CapacityReservationLevel`
    info	[Changelog] - New value `DataSourceTypeIngestion` added to enum type `DataSourceType`
    info	[Changelog] - New value `IdentityTypeApplication`, `IdentityTypeKey`, `IdentityTypeManagedIdentity`, `IdentityTypeUser` added to enum type `IdentityType`
    info	[Changelog] - New enum type `ColumnDataTypeHintEnum` with values `ColumnDataTypeHintEnumArmPath`, `ColumnDataTypeHintEnumGUID`, `ColumnDataTypeHintEnumIP`, `ColumnDataTypeHintEnumURI`
    info	[Changelog] - New enum type `ColumnTypeEnum` with values `ColumnTypeEnumBoolean`, `ColumnTypeEnumDateTime`, `ColumnTypeEnumDynamic`, `ColumnTypeEnumGUID`, `ColumnTypeEnumInt`, `ColumnTypeEnumLong`, `ColumnTypeEnumReal`, `ColumnTypeEnumString`
    info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
    info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
    info	[Changelog] - New enum type `ProvisioningStateEnum` with values `ProvisioningStateEnumDeleting`, `ProvisioningStateEnumInProgress`, `ProvisioningStateEnumSucceeded`, `ProvisioningStateEnumUpdating`
    info	[Changelog] - New enum type `SourceEnum` with values `SourceEnumCustomer`, `SourceEnumMicrosoft`
    info	[Changelog] - New enum type `TablePlanEnum` with values `TablePlanEnumAnalytics`, `TablePlanEnumBasic`
    info	[Changelog] - New enum type `TableSubTypeEnum` with values `TableSubTypeEnumAny`, `TableSubTypeEnumClassic`, `TableSubTypeEnumDataCollectionRuleBased`
    info	[Changelog] - New enum type `TableTypeEnum` with values `TableTypeEnumCustomLog`, `TableTypeEnumMicrosoft`, `TableTypeEnumRestoredLogs`, `TableTypeEnumSearchResults`
    info	[Changelog] - New function `*ClientFactory.NewQueriesClient() *QueriesClient`
    info	[Changelog] - New function `*ClientFactory.NewQueryPacksClient() *QueryPacksClient`
    info	[Changelog] - New function `NewQueriesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QueriesClient, error)`
    info	[Changelog] - New function `*QueriesClient.Delete(context.Context, string, string, string, *QueriesClientDeleteOptions) (QueriesClientDeleteResponse, error)`
    info	[Changelog] - New function `*QueriesClient.Get(context.Context, string, string, string, *QueriesClientGetOptions) (QueriesClientGetResponse, error)`
    info	[Changelog] - New function `*QueriesClient.NewListPager(string, string, *QueriesClientListOptions) *runtime.Pager[QueriesClientListResponse]`
    info	[Changelog] - New function `*QueriesClient.Put(context.Context, string, string, string, LogAnalyticsQueryPackQuery, *QueriesClientPutOptions) (QueriesClientPutResponse, error)`
    info	[Changelog] - New function `*QueriesClient.NewSearchPager(string, string, LogAnalyticsQueryPackQuerySearchProperties, *QueriesClientSearchOptions) *runtime.Pager[QueriesClientSearchResponse]`
    info	[Changelog] - New function `*QueriesClient.Update(context.Context, string, string, string, LogAnalyticsQueryPackQuery, *QueriesClientUpdateOptions) (QueriesClientUpdateResponse, error)`
    info	[Changelog] - New function `NewQueryPacksClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QueryPacksClient, error)`
    info	[Changelog] - New function `*QueryPacksClient.CreateOrUpdate(context.Context, string, string, LogAnalyticsQueryPack, *QueryPacksClientCreateOrUpdateOptions) (QueryPacksClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.CreateOrUpdateWithoutName(context.Context, string, LogAnalyticsQueryPack, *QueryPacksClientCreateOrUpdateWithoutNameOptions) (QueryPacksClientCreateOrUpdateWithoutNameResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.Delete(context.Context, string, string, *QueryPacksClientDeleteOptions) (QueryPacksClientDeleteResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.Get(context.Context, string, string, *QueryPacksClientGetOptions) (QueryPacksClientGetResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.NewListByResourceGroupPager(string, *QueryPacksClientListByResourceGroupOptions) *runtime.Pager[QueryPacksClientListByResourceGroupResponse]`
    info	[Changelog] - New function `*QueryPacksClient.NewListPager(*QueryPacksClientListOptions) *runtime.Pager[QueryPacksClientListResponse]`
    info	[Changelog] - New function `*QueryPacksClient.UpdateTags(context.Context, string, string, TagsResource, *QueryPacksClientUpdateTagsOptions) (QueryPacksClientUpdateTagsResponse, error)`
    info	[Changelog] - New function `*TablesClient.CancelSearch(context.Context, string, string, string, *TablesClientCancelSearchOptions) (TablesClientCancelSearchResponse, error)`
    info	[Changelog] - New function `*TablesClient.BeginCreateOrUpdate(context.Context, string, string, string, Table, *TablesClientBeginCreateOrUpdateOptions) (*runtime.Poller[TablesClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*TablesClient.BeginDelete(context.Context, string, string, string, *TablesClientBeginDeleteOptions) (*runtime.Poller[TablesClientDeleteResponse], error)`
    info	[Changelog] - New function `*TablesClient.Migrate(context.Context, string, string, string, *TablesClientMigrateOptions) (TablesClientMigrateResponse, error)`
    info	[Changelog] - New struct `AzureResourceProperties`
    info	[Changelog] - New struct `Column`
    info	[Changelog] - New struct `LogAnalyticsQueryPack`
    info	[Changelog] - New struct `LogAnalyticsQueryPackListResult`
    info	[Changelog] - New struct `LogAnalyticsQueryPackProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuery`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryListResult`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryPropertiesRelated`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuerySearchProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuerySearchPropertiesRelated`
    info	[Changelog] - New struct `ManagedServiceIdentity`
    info	[Changelog] - New struct `QueryPacksResource`
    info	[Changelog] - New struct `RestoredLogs`
    info	[Changelog] - New struct `ResultStatistics`
    info	[Changelog] - New struct `Schema`
    info	[Changelog] - New struct `SearchResults`
    info	[Changelog] - New struct `SystemData`
    info	[Changelog] - New struct `SystemDataAutoGenerated`
    info	[Changelog] - New struct `TagsResource`
    info	[Changelog] - New struct `UserAssignedIdentity`
    info	[Changelog] - New field `SystemData` in struct `Table`
    info	[Changelog] - New field `ArchiveRetentionInDays`, `LastPlanModifiedDate`, `Plan`, `ProvisioningState`, `RestoredLogs`, `ResultStatistics`, `RetentionInDaysAsDefault`, `Schema`, `SearchResults`, `TotalRetentionInDays`, `TotalRetentionInDaysAsDefault` in struct `TableProperties`
    info	[Changelog] - New field `Identity`, `SystemData` in struct `Workspace`
    info	[Changelog] - New field `UnifiedSentinelBillingOnly` in struct `WorkspaceFeatures`
    info	[Changelog] - New field `Identity` in struct `WorkspacePatch`
    info	[Changelog] - New field `DefaultDataCollectionRuleResourceID` in struct `WorkspaceProperties`
    info	[Changelog]
    info	[Changelog] Total 3 breaking change(s), 128 additive change(s).
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Operation `*TablesClient.Update` has been changed to LRO, use `*TablesClient.BeginUpdate` instead.
    - Type of `Cluster.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    - Type of `ClusterPatch.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 9c31b23fb084430286c75be5fe926b3fea6cd89e. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]  notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-loganalytics [Preview SDK Changes] Breaking Change Detected
    • azure-mgmt-loganalytics-7.0.0b1.zip
    • azure_mgmt_loganalytics-7.0.0b1-py3-none-any.whl
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation TablesOperations.begin_create_or_update
    info	[Changelog]   - Added operation TablesOperations.begin_delete
    info	[Changelog]   - Added operation TablesOperations.cancel_search
    info	[Changelog]   - Added operation TablesOperations.migrate
    info	[Changelog]   - Added operation group QueriesOperations
    info	[Changelog]   - Added operation group QueryPacksOperations
    info	[Changelog]   - Model Table has a new parameter archive_retention_in_days
    info	[Changelog]   - Model Table has a new parameter last_plan_modified_date
    info	[Changelog]   - Model Table has a new parameter plan
    info	[Changelog]   - Model Table has a new parameter provisioning_state
    info	[Changelog]   - Model Table has a new parameter restored_logs
    info	[Changelog]   - Model Table has a new parameter result_statistics
    info	[Changelog]   - Model Table has a new parameter retention_in_days_as_default
    info	[Changelog]   - Model Table has a new parameter schema
    info	[Changelog]   - Model Table has a new parameter search_results
    info	[Changelog]   - Model Table has a new parameter system_data
    info	[Changelog]   - Model Table has a new parameter total_retention_in_days
    info	[Changelog]   - Model Table has a new parameter total_retention_in_days_as_default
    info	[Changelog]   - Model Workspace has a new parameter default_data_collection_rule_resource_id
    info	[Changelog]   - Model Workspace has a new parameter etag
    info	[Changelog]   - Model Workspace has a new parameter identity
    info	[Changelog]   - Model Workspace has a new parameter system_data
    info	[Changelog]   - Model WorkspaceFeatures has a new parameter unified_sentinel_billing_only
    info	[Changelog]   - Model WorkspacePatch has a new parameter default_data_collection_rule_resource_id
    info	[Changelog]   - Model WorkspacePatch has a new parameter identity
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model Table no longer has parameter is_troubleshoot_enabled
    info	[Changelog]   - Model Table no longer has parameter is_troubleshooting_allowed
    info	[Changelog]   - Model Table no longer has parameter last_troubleshoot_date
    info	[Changelog]   - Model Workspace no longer has parameter e_tag
    info	[Changelog]   - Removed operation TablesOperations.create
    info	[Changelog]   - Renamed operation TablesOperations.update to TablesOperations.begin_update
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Model Table no longer has parameter is_troubleshoot_enabled
    - Model Table no longer has parameter is_troubleshooting_allowed
    - Model Table no longer has parameter last_troubleshoot_date
    - Model Workspace no longer has parameter e_tag
    - Removed operation TablesOperations.create
    - Renamed operation TablesOperations.update to TablesOperations.begin_update
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9c31b23fb084430286c75be5fe926b3fea6cd89e. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-operationalinsights [Preview SDK Changes] Breaking Change Detected
    • azure-arm-operationalinsights-10.0.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Interface ManagedServiceIdentity
    info	[Changelog]   - Added Interface UserAssignedIdentity
    info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
    info	[Changelog]   - Interface WorkspaceFeatures has a new optional parameter unifiedSentinelBillingOnly
    info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
    info	[Changelog]   - Enum KnownProvisioningStateEnum has a new value Deleting
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Type of parameter systemData of interface AzureResourceProperties is changed from SystemData to SystemDataAutoGenerated
    info	[Changelog]   - Type of parameter identity of interface Cluster is changed from Identity to ManagedServiceIdentity
    info	[Changelog]   - Type of parameter identity of interface ClusterPatch is changed from Identity to ManagedServiceIdentity
    info	[Changelog]   - Type of parameter createdByType of interface SystemData is changed from IdentityType to CreatedByType
    info	[Changelog]   - Type of parameter lastModifiedByType of interface SystemData is changed from IdentityType to CreatedByType
    info	[Changelog]   - Type of parameter createdByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    info	[Changelog]   - Type of parameter lastModifiedByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    info	[Changelog]   - Type of parameter systemData of interface Table is changed from SystemDataAutoGenerated to SystemData
    info	[Changelog]   - Type of parameter systemData of interface Workspace is changed from SystemDataAutoGenerated to SystemData
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Type of parameter createdByType of interface SystemData is changed from IdentityType to CreatedByType
    - Type of parameter createdByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    - Type of parameter identity of interface Cluster is changed from Identity to ManagedServiceIdentity
    - Type of parameter identity of interface ClusterPatch is changed from Identity to ManagedServiceIdentity
    - Type of parameter lastModifiedByType of interface SystemData is changed from IdentityType to CreatedByType
    - Type of parameter lastModifiedByType of interface SystemDataAutoGenerated is changed from CreatedByType to IdentityType
    - Type of parameter systemData of interface AzureResourceProperties is changed from SystemData to SystemDataAutoGenerated
    - Type of parameter systemData of interface Table is changed from SystemDataAutoGenerated to SystemData
    - Type of parameter systemData of interface Workspace is changed from SystemDataAutoGenerated to SystemData
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9c31b23fb084430286c75be5fe926b3fea6cd89e. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-loganalytics [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-loganalytics-1.1.0-beta.1-sources.jar
    • azure-resourcemanager-loganalytics-1.1.0-beta.1.jar
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from 9c31b23fb084430286c75be5fe926b3fea6cd89e. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 9c31b23fb084430286c75be5fe926b3fea6cd89e. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.operationalinsights.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@wuxu92 any chance we can reopen this one?

tombuildsstuff avatar Mar 21 '24 08:03 tombuildsstuff

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Labels were wrong: this PR is not ready for ARM review yet. Always use this comment for guidance: it is updated as your PR moves through the process: https://github.com/Azure/azure-rest-api-specs/pull/27524#issuecomment-1909426449.

mentat9 avatar May 16 '24 19:05 mentat9

I can't reopen it because there's no button for that on the page.

wuxu92 avatar Jun 18 '24 00:06 wuxu92