azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Xuhumsft securityinsights microsoft.security insights 2023 12 01 preview

Open xuhumsft opened this issue 1 year ago • 15 comments

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page. If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested is removed from your PR. This should cause the label WaitForARMFeedback to be added. [2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [x] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix swagger quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

xuhumsft avatar Dec 30 '23 02:12 xuhumsft

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 14 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
AlertRules.json 2023-12-01-preview(434f587) 2023-11-01(main)
AlertRules.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
AutomationRules.json 2023-12-01-preview(434f587) 2023-11-01(main)
AutomationRules.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
BillingStatistics.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Bookmarks.json 2023-12-01-preview(434f587) 2023-11-01(main)
Bookmarks.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
ContentPackages.json 2023-12-01-preview(434f587) 2023-11-01(main)
ContentPackages.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
ContentProductPackages.json 2023-12-01-preview(434f587) 2023-11-01(main)
ContentProductPackages.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
ContentProductTemplates.json 2023-12-01-preview(434f587) 2023-11-01(main)
ContentProductTemplates.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
ContentTemplates.json 2023-12-01-preview(434f587) 2023-11-01(main)
ContentTemplates.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Enrichment.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Entities.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
EntityQueries.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
EntityQueryTemplates.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
FileImports.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Hunts.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Incidents.json 2023-12-01-preview(434f587) 2023-11-01(main)
Incidents.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Metadata.json 2023-12-01-preview(434f587) 2023-11-01(main)
Metadata.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
OfficeConsents.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
OnboardingStates.json 2023-12-01-preview(434f587) 2023-11-01(main)
OnboardingStates.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Recommendations.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
SecurityMLAnalyticsSettings.json 2023-12-01-preview(434f587) 2023-11-01(main)
SecurityMLAnalyticsSettings.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Settings.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
SourceControls.json 2023-12-01-preview(434f587) 2023-11-01(main)
SourceControls.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
ThreatIntelligence.json 2023-12-01-preview(434f587) 2023-11-01(main)
ThreatIntelligence.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
TriggeredAnalyticsRuleRuns.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
Watchlists.json 2023-12-01-preview(434f587) 2023-11-01(main)
Watchlists.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
WorkspaceManagerAssignments.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
WorkspaceManagerConfigurations.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
WorkspaceManagerGroups.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
WorkspaceManagerMembers.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
AlertTypes.json 2023-12-01-preview(434f587) 2023-11-01(main)
AlertTypes.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
ContentCommonTypes.json 2023-12-01-preview(434f587) 2023-11-01(main)
ContentCommonTypes.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
EntityTypes.json 2023-12-01-preview(434f587) 2023-11-01(main)
EntityTypes.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
IncidentTypes.json 2023-12-01-preview(434f587) 2023-11-01(main)
IncidentTypes.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
RelationTypes.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
ThreatIntelligenceTypes.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
dataConnectorDefinitions.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
dataConnectors.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)
operations.json 2023-12-01-preview(434f587) 2023-11-01(main)
operations.json 2023-12-01-preview(434f587) 2023-10-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 11 items are listed, please refer to log for more details.

Rule Message
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/Incidents.json#L1315:9
Old: Microsoft.SecurityInsights/stable/2023-11-01/Incidents.json#L1102:9
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/Incidents.json#L1319:9
Old: Microsoft.SecurityInsights/stable/2023-11-01/Incidents.json#L1138:9
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/Incidents.json#L1312:9
Old: Microsoft.SecurityInsights/stable/2023-11-01/Incidents.json#L1245:9
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L2424:11
Old: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L533:11
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L326:13
Old: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L317:13
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L375:13
Old: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L366:13
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L381:13
Old: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L372:13
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L2383:5
Old: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L579:5
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L1583:9
Old: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1053:9
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L1600:5
Old: Microsoft.SecurityInsights/stable/2023-11-01/AlertRules.json#L1070:5
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/Metadata.json#L250:9
Old: Microsoft.SecurityInsights/stable/2023-11-01/Metadata.json#L250:9


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
:warning: 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'resourceId' renamed or removed?
:warning: 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'resourceId' renamed or removed?
New: Microsoft.SecurityInsights/preview/2023-12-01-preview/ContentProductPackages.json#L200:7
Old: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductPackages.json#L200:7
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 60 Errors, 389 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-12 package-preview-2023-12(434f587) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 11 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L781
RPC-Policy-V1-05, RPC-Put-V1-23
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L1792
RPC-Policy-V1-05, RPC-Put-V1-23
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L1993
RPC-Policy-V1-05, RPC-Put-V1-23
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L2060
RPC-Policy-V1-05, RPC-Put-V1-23
ResourceNameRestriction The resource name parameter 'relationName' should be defined with a 'pattern' restriction.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/Bookmarks.json#L331
RPC-Uri-V1-05
ArrayMustHaveType 'items.type' property must be truthy
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/dataConnectors.json#L2393
ArrayMustHaveType 'items.type' property must be truthy
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/dataConnectors.json#L2405
ArrayMustHaveType 'items.type' property must be truthy
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/dataConnectors.json#L2417
ArrayMustHaveType 'items.type' property must be truthy
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/dataConnectors.json#L2429
ArrayMustHaveType 'items.type' property must be truthy
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/dataConnectors.json#L2449
ArrayMustHaveType 'items.type' property must be truthy
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/dataConnectors.json#L2825


The following errors/warnings exist before current PR submission:

Only 11 items are listed, please refer to log for more details.

Rule Message
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Actions_CreateOrUpdate' Request Model: 'parameters[6].schema' Response Model: 'responses[200].schema'
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L338
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L1639
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L1926
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L1957
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L2043
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AlertRules.json#L2103
DeleteResponseBodyEmpty The delete response body must be empty.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AutomationRules.json#L148
DeleteResponseBodyEmpty The delete response body must be empty.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/AutomationRules.json#L154
ResourceNameRestriction The resource name parameter 'relationName' should be defined with a 'pattern' restriction.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/Incidents.json#L698
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/Incidents.json#L1143
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2023-12-01-preview/Incidents.json#L1159
️❌Avocado: 67 Errors, 0 Warnings failed [Detail]

Only 11 items are listed, please refer to log for more details.

Rule Message
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/aggregations/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Aggregations.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/automationRules is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/automationRules/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{}/relations is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{}/expand is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{}/relations/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/cases is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Cases.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/cases/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Cases.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/cases/{}/comments is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/securityinsights/resource-manager/readme.md
json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Cases.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/securityinsights/armsecurityinsights - Approved - 2.0.0-beta.4
+	Enum `EntityKind` has been removed
+	Enum `Enum13` has been removed
+	Enum `Enum15` has been removed
+	Enum `ThreatIntelligenceResourceKindEnum` has been removed
+	Enum `ThreatIntelligenceSortingCriteriaEnum` has been removed
+	Field `BingSafetyPhishingURL` of struct `MSTIDataConnectorDataTypes` has been removed
+	Field `PathMapping` of struct `Repository` has been removed
+	Function `*IncidentsClient.CreateTeam` parameter(s) have been changed from `(context.Context, string, string, string, TeamProperties, *IncidentsClientCreateTeamOptions)` to `(context.Context, string, string, string, TeamInformation, *IncidentsClientCreateTeamOptions)`
+	Function `*SourceControlClient.NewListRepositoriesPager` parameter(s) have been changed from `(string, string, RepoType, *SourceControlClientListRepositoriesOptions)` to `(string, string, RepositoryAccessProperties, *SourceControlClientListRepositoriesOptions)`
+	Function `*SourceControlsClient.Delete` parameter(s) have been changed from `(context.Context, string, string, string, *SourceControlsClientDeleteOptions)` to `(context.Context, string, string, string, RepositoryAccessProperties, *SourceControlsClientDeleteOptions)`
+	Struct `ContentPathMap` has been removed
+	Struct `MSTIDataConnectorDataTypesBingSafetyPhishingURL` has been removed
+	Struct `TeamProperties` has been removed
+	Type of `AccountEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `AzureResourceEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `CloudApplicationEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `DNSEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `Entity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `EntityQueriesClientListOptions.Kind` has been changed from `*Enum13` to `*Enum20`
+	Type of `EntityQueryTemplatesClientListOptions.Kind` has been changed from `*Enum15` to `*Enum22`
+	Type of `ExpansionResultAggregation.EntityKind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `FileEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `FileHashEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `HostEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `HuntingBookmark.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `IPEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `IncidentEntitiesResultsMetadata.EntityKind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `IoTDeviceEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MailClusterEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MailMessageEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MailboxEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MalwareEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MetadataProperties.Kind` has been changed from `*Kind` to `*string`
+	Type of `MetadataPropertiesPatch.Kind` has been changed from `*Kind` to `*string`
+	Type of `NicEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `ProcessEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `RegistryKeyEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `RegistryValueEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `SecurityAlert.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `SecurityGroupEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `SubmissionMailEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `ThreatIntelligenceIndicatorModel.Kind` has been changed from `*ThreatIntelligenceResourceKindEnum` to `*ThreatIntelligenceResourceInnerKind`
+	Type of `ThreatIntelligenceInformation.Kind` has been changed from `*ThreatIntelligenceResourceKindEnum` to `*ThreatIntelligenceResourceInnerKind`
+	Type of `ThreatIntelligenceSortingCriteria.SortOrder` has been changed from `*ThreatIntelligenceSortingCriteriaEnum` to `*ThreatIntelligenceSortingOrder`
+	Type of `URLEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `Webhook.WebhookSecretUpdateTime` has been changed from `*string` to `*time.Time`
+	`RepoTypeDevOps` from enum `RepoType` has been removed
azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - Approved - 2.0.0b2
+	Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
+	Model Repository no longer has parameter path_mapping
+	Operation SourceControlOperations.list_repositories has a new required parameter repository_access
+	Operation SourceControlOperations.list_repositories no longer has parameter repo_type
+	Operation SourceControlsOperations.delete has a new required parameter repository_access
+	Parameter branch of model Repository is now required
+	Parameter content_types of model SourceControl is now required
+	Parameter display_name of model SourceControl is now required
+	Parameter logic_app_resource_id of model PlaybookActionProperties is now required
+	Parameter repo_type of model SourceControl is now required
+	Parameter repository of model SourceControl is now required
+	Parameter url of model Repository is now required
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 7e6c2c7ae1fcfa9791bbb79de68f287f74baa009. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.SecurityInsights [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 7e6c2c7ae1fcfa9791bbb79de68f287f74baa009. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/securityinsights/armsecurityinsights [View full logs]  [Preview SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog] - New function `NewWorkspaceManagerMembersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*WorkspaceManagerMembersClient, error)`
    info	[Changelog] - New function `*WorkspaceManagerMembersClient.CreateOrUpdate(context.Context, string, string, string, WorkspaceManagerMember, *WorkspaceManagerMembersClientCreateOrUpdateOptions) (WorkspaceManagerMembersClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*WorkspaceManagerMembersClient.Delete(context.Context, string, string, string, *WorkspaceManagerMembersClientDeleteOptions) (WorkspaceManagerMembersClientDeleteResponse, error)`
    info	[Changelog] - New function `*WorkspaceManagerMembersClient.Get(context.Context, string, string, string, *WorkspaceManagerMembersClientGetOptions) (WorkspaceManagerMembersClientGetResponse, error)`
    info	[Changelog] - New function `*WorkspaceManagerMembersClient.NewListPager(string, string, *WorkspaceManagerMembersClientListOptions) *runtime.Pager[WorkspaceManagerMembersClientListResponse]`
    info	[Changelog] - New struct `AddIncidentTaskActionProperties`
    info	[Changelog] - New struct `AlertPropertyMapping`
    info	[Changelog] - New struct `AnalyticsRuleRunTrigger`
    info	[Changelog] - New struct `AnalyticsRuleRunTriggerProperties`
    info	[Changelog] - New struct `AssignmentItem`
    info	[Changelog] - New struct `AutomationRuleAddIncidentTaskAction`
    info	[Changelog] - New struct `BillingStatisticList`
    info	[Changelog] - New struct `ConnectivityCriterion`
    info	[Changelog] - New struct `ConnectorDataType`
    info	[Changelog] - New struct `ConnectorDefinitionsAvailability`
    info	[Changelog] - New struct `ConnectorDefinitionsPermissions`
    info	[Changelog] - New struct `ConnectorDefinitionsResourceProvider`
    info	[Changelog] - New struct `Content`
    info	[Changelog] - New struct `CustomPermissionDetails`
    info	[Changelog] - New struct `CustomizableConnectionsConfig`
    info	[Changelog] - New struct `CustomizableConnectorDefinition`
    info	[Changelog] - New struct `CustomizableConnectorDefinitionProperties`
    info	[Changelog] - New struct `CustomizableConnectorUIConfig`
    info	[Changelog] - New struct `DCRConfiguration`
    info	[Changelog] - New struct `DataConnectorDefinitionArmCollectionWrapper`
    info	[Changelog] - New struct `EntityManualTriggerRequestBody`
    info	[Changelog] - New struct `Error`
    info	[Changelog] - New struct `GCPAuthProperties`
    info	[Changelog] - New struct `GCPDataConnector`
    info	[Changelog] - New struct `GCPDataConnectorProperties`
    info	[Changelog] - New struct `GCPRequestProperties`
    info	[Changelog] - New struct `GraphQuery`
    info	[Changelog] - New struct `Hunt`
    info	[Changelog] - New struct `HuntComment`
    info	[Changelog] - New struct `HuntCommentList`
    info	[Changelog] - New struct `HuntCommentProperties`
    info	[Changelog] - New struct `HuntList`
    info	[Changelog] - New struct `HuntOwner`
    info	[Changelog] - New struct `HuntProperties`
    info	[Changelog] - New struct `HuntRelation`
    info	[Changelog] - New struct `HuntRelationList`
    info	[Changelog] - New struct `HuntRelationProperties`
    info	[Changelog] - New struct `IncidentTask`
    info	[Changelog] - New struct `IncidentTaskList`
    info	[Changelog] - New struct `IncidentTaskProperties`
    info	[Changelog] - New struct `InstructionStep`
    info	[Changelog] - New struct `InstructionStepDetails`
    info	[Changelog] - New struct `Instructions`
    info	[Changelog] - New struct `Job`
    info	[Changelog] - New struct `JobItem`
    info	[Changelog] - New struct `JobList`
    info	[Changelog] - New struct `JobProperties`
    info	[Changelog] - New struct `MTPDataConnectorDataTypesAlerts`
    info	[Changelog] - New struct `MicrosoftPurviewInformationProtectionCheckRequirements`
    info	[Changelog] - New struct `MicrosoftPurviewInformationProtectionCheckRequirementsProperties`
    info	[Changelog] - New struct `MicrosoftPurviewInformationProtectionConnectorDataTypes`
    info	[Changelog] - New struct `MicrosoftPurviewInformationProtectionConnectorDataTypesLogs`
    info	[Changelog] - New struct `MicrosoftPurviewInformationProtectionDataConnector`
    info	[Changelog] - New struct `MicrosoftPurviewInformationProtectionDataConnectorProperties`
    info	[Changelog] - New struct `MtpFilteredProviders`
    info	[Changelog] - New struct `PackageList`
    info	[Changelog] - New struct `PackageModel`
    info	[Changelog] - New struct `PackageProperties`
    info	[Changelog] - New struct `ProductPackageList`
    info	[Changelog] - New struct `ProductPackageModel`
    info	[Changelog] - New struct `ProductPackageProperties`
    info	[Changelog] - New struct `ProductTemplateList`
    info	[Changelog] - New struct `ProductTemplateModel`
    info	[Changelog] - New struct `ProductTemplateProperties`
    info	[Changelog] - New struct `PullRequest`
    info	[Changelog] - New struct `Recommendation`
    info	[Changelog] - New struct `RecommendationList`
    info	[Changelog] - New struct `RecommendationPatch`
    info	[Changelog] - New struct `RecommendedAction`
    info	[Changelog] - New struct `RepositoryAccess`
    info	[Changelog] - New struct `RepositoryAccessObject`
    info	[Changelog] - New struct `RepositoryAccessProperties`
    info	[Changelog] - New struct `ResourceProviderRequiredPermissions`
    info	[Changelog] - New struct `SampleQuery`
    info	[Changelog] - New struct `SapSolutionUsageStatistic`
    info	[Changelog] - New struct `SapSolutionUsageStatisticProperties`
    info	[Changelog] - New struct `SentinelEntityMapping`
    info	[Changelog] - New struct `ServicePrincipal`
    info	[Changelog] - New struct `TemplateList`
    info	[Changelog] - New struct `TemplateModel`
    info	[Changelog] - New struct `TemplateProperties`
    info	[Changelog] - New struct `TriggeredAnalyticsRuleRun`
    info	[Changelog] - New struct `TriggeredAnalyticsRuleRunProperties`
    info	[Changelog] - New struct `TriggeredAnalyticsRuleRuns`
    info	[Changelog] - New struct `Warning`
    info	[Changelog] - New struct `WarningBody`
    info	[Changelog] - New struct `WorkspaceManagerAssignment`
    info	[Changelog] - New struct `WorkspaceManagerAssignmentList`
    info	[Changelog] - New struct `WorkspaceManagerAssignmentProperties`
    info	[Changelog] - New struct `WorkspaceManagerConfiguration`
    info	[Changelog] - New struct `WorkspaceManagerConfigurationList`
    info	[Changelog] - New struct `WorkspaceManagerConfigurationProperties`
    info	[Changelog] - New struct `WorkspaceManagerGroup`
    info	[Changelog] - New struct `WorkspaceManagerGroupList`
    info	[Changelog] - New struct `WorkspaceManagerGroupProperties`
    info	[Changelog] - New struct `WorkspaceManagerMember`
    info	[Changelog] - New struct `WorkspaceManagerMemberProperties`
    info	[Changelog] - New struct `WorkspaceManagerMembersList`
    info	[Changelog] - New field `AlertDynamicProperties` in struct `AlertDetailsOverride`
    info	[Changelog] - New field `SubTechniques` in struct `FusionAlertRuleProperties`
    info	[Changelog] - New field `SubTechniques` in struct `FusionAlertRuleTemplateProperties`
    info	[Changelog] - New field `SubTechniques` in struct `MLBehaviorAnalyticsAlertRuleProperties`
    info	[Changelog] - New field `Alerts` in struct `MTPDataConnectorDataTypes`
    info	[Changelog] - New field `FilteredProviders` in struct `MTPDataConnectorProperties`
    info	[Changelog] - New field `SentinelEntitiesMappings`, `SubTechniques` in struct `NrtAlertRuleProperties`
    info	[Changelog] - New field `SentinelEntitiesMappings` in struct `NrtAlertRuleTemplateProperties`
    info	[Changelog] - New field `InstallationID` in struct `Repo`
    info	[Changelog] - New field `SentinelEntitiesMappings`, `SubTechniques` in struct `ScheduledAlertRuleProperties`
    info	[Changelog] - New field `SentinelEntitiesMappings`, `SubTechniques` in struct `ScheduledAlertRuleTemplateProperties`
    info	[Changelog] - New field `Intent`, `Techniques` in struct `SecurityAlertTimelineItem`
    info	[Changelog] - New field `PullRequest`, `RepositoryAccess`, `ServicePrincipal` in struct `SourceControlProperties`
    info	[Changelog] - New anonymous field `Warning` in struct `SourceControlsClientDeleteResponse`
    info	[Changelog] - New field `SubTechniques` in struct `ThreatIntelligenceAlertRuleProperties`
    info	[Changelog]
    info	[Changelog] Total 50 breaking change(s), 458 additive change(s).
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 7e6c2c7ae1fcfa9791bbb79de68f287f74baa009. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation EntitiesOperations.run_playbook
    info	[Changelog]   - Added operation group AlertRuleOperations
    info	[Changelog]   - Added operation group BillingStatisticsOperations
    info	[Changelog]   - Added operation group ContentPackageOperations
    info	[Changelog]   - Added operation group ContentPackagesOperations
    info	[Changelog]   - Added operation group ContentTemplateOperations
    info	[Changelog]   - Added operation group ContentTemplatesOperations
    info	[Changelog]   - Added operation group DataConnectorDefinitionsOperations
    info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
    info	[Changelog]   - Added operation group HuntCommentsOperations
    info	[Changelog]   - Added operation group HuntRelationsOperations
    info	[Changelog]   - Added operation group HuntsOperations
    info	[Changelog]   - Added operation group ProductPackageOperations
    info	[Changelog]   - Added operation group ProductPackagesOperations
    info	[Changelog]   - Added operation group ProductTemplateOperations
    info	[Changelog]   - Added operation group ProductTemplatesOperations
    info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
    info	[Changelog]   - Added operation group WorkspaceManagerAssignmentJobsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerAssignmentsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerConfigurationsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerGroupsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerMembersOperations
    info	[Changelog]   - Model FusionAlertRule has a new parameter sub_techniques
    info	[Changelog]   - Model FusionAlertRuleTemplate has a new parameter sub_techniques
    info	[Changelog]   - Model MLBehaviorAnalyticsAlertRule has a new parameter sub_techniques
    info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
    info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
    info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
    info	[Changelog]   - Model NrtAlertRule has a new parameter sub_techniques
    info	[Changelog]   - Model Repo has a new parameter installation_id
    info	[Changelog]   - Model ScheduledAlertRule has a new parameter sub_techniques
    info	[Changelog]   - Model ScheduledAlertRuleProperties has a new parameter sub_techniques
    info	[Changelog]   - Model ScheduledAlertRuleTemplate has a new parameter sub_techniques
    info	[Changelog]   - Model SourceControl has a new parameter pull_request
    info	[Changelog]   - Model SourceControl has a new parameter repository_access
    info	[Changelog]   - Model SourceControl has a new parameter service_principal
    info	[Changelog]   - Model ThreatIntelligenceAlertRule has a new parameter sub_techniques
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
    info	[Changelog]   - Model Repository no longer has parameter path_mapping
    info	[Changelog]   - Operation SourceControlOperations.list_repositories has a new required parameter repository_access
    info	[Changelog]   - Operation SourceControlOperations.list_repositories no longer has parameter repo_type
    info	[Changelog]   - Operation SourceControlsOperations.delete has a new required parameter repository_access
    info	[Changelog]   - Parameter branch of model Repository is now required
    info	[Changelog]   - Parameter content_types of model SourceControl is now required
    info	[Changelog]   - Parameter display_name of model SourceControl is now required
    info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required
    info	[Changelog]   - Parameter repo_type of model SourceControl is now required
    info	[Changelog]   - Parameter repository of model SourceControl is now required
    info	[Changelog]   - Parameter url of model Repository is now required
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 7e6c2c7ae1fcfa9791bbb79de68f287f74baa009. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
    info	[Changelog]   - Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
    info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
    info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
    info	[Changelog]   - Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
    info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter webhookSecretUpdateTime of interface Webhook is changed from string to Date
    info	[Changelog]   - Removed Enum KnownEntityKind
    info	[Changelog]   - Removed Enum KnownEnum13
    info	[Changelog]   - Removed Enum KnownThreatIntelligenceResourceKindEnum
    info	[Changelog]   - Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
    info	[Changelog]   - Enum KnownRepoType no longer has value DevOps
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 7e6c2c7ae1fcfa9791bbb79de68f287f74baa009. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] t
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
    100 15916  100 15916    0     0   777k      0 --:--:-- --:--:-- --:--:--  777k
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-securityinsights [View full logs]  [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed [Logs] Generate from 7e6c2c7ae1fcfa9791bbb79de68f287f74baa009. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • securityinsights/resource-manager [View full logs
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from 7e6c2c7ae1fcfa9791bbb79de68f287f74baa009. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.securityinsights.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/securityinsights/armsecurityinsights https://apiview.dev/Assemblies/Review/002d4025b23b4299a8d5ac660d16826d?revisionId=4c56bf4ce0534cdd9bcd7621498e4b89
.Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version
Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/94d98f0a635f4ee98bd2349d9b276a14?revisionId=b03782000afd4b2f93517a06d0313f78
JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/495feca01b564258a5b2e6d5ed3ad0e2?revisionId=615cf29776b14b38ae8cd735488bdae0
Swagger Microsoft.SecurityInsights https://apiview.dev/Assemblies/Review/d30cc3bd7c484ad880bc3b8126f67ba5?revisionId=019d244e21594a4f8f30b71182f9f1ce

This branch is created due to the conflict after merging 2023-11-01-stable version in the readme.md. For the commit [SupportSubTechniques] - Add sub techniques to swagger., it is already reviewed and approved in https://github.com/Azure/azure-rest-api-specs/pull/27031

xuhumsft avatar Dec 30 '23 02:12 xuhumsft

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Hi @xuhumsft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

@xuhumsft - Couple of things needed before ARM review:

  1. Complete the intake form (Due diligence checklist).
  2. Address this comment: https://github.com/Azure/azure-rest-api-specs/pull/27214#issuecomment-1872433306. Since one of the changes is to rename a property, we need to see the changes compared against your currently shipping API.

If you need to make a new PR be sure to include your comment about previous ARM review.

mentat9 avatar Jan 11 '24 02:01 mentat9

/azp run typespec requirement

mikeharder avatar Jan 11 '24 07:01 mikeharder

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 11 '24 07:01 azure-pipelines[bot]

@xuhumsft - Couple of things needed before ARM review:

  1. Complete the intake form (Due diligence checklist).
  2. Address this comment: Xuhumsft securityinsights microsoft.security insights 2023 12 01 preview #27214 (comment). Since one of the changes is to rename a property, we need to see the changes compared against your currently shipping API.

If you need to make a new PR be sure to include your comment about previous ARM review.

Hi @mentat9 , Thank you for your advice. Could you please elaborate so that it can help me in future PRs?

For the 1st one. I am kind of confuse with some in the box. It seems the problem is related to old versions several years ago. Could you please help me figure out how to fix them? If you think I should talk to someone, please let me know. We also want to have clear status for future review.

For [Xuhumsft securityinsights microsoft.security insights 2023 12 01 preview #27214 (comment)], this branch is generated by OpenAPI Hub with 10-01-preview and the first three commits are generated by the hub. Do you mean I should check another commit after the first 3 commits? Could you give me an example.

This time I did not find any comments from previous PR but I will include, if any, for future PRs.

Thanks again for your advices.

xuhumsft avatar Jan 11 '24 21:01 xuhumsft

/azp run

mikekistler avatar Jan 19 '24 02:01 mikekistler

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar Jan 19 '24 02:01 azure-pipelines[bot]

The breaking change was reviewed in SCENARIO 26415064.

xuhumsft avatar Jan 19 '24 20:01 xuhumsft

Can you please fix the swagger lintdiff errors : https://github.com/Azure/azure-rest-api-specs/pull/27214/checks?check_run_id=20641614682

raosuhas avatar Jan 22 '24 22:01 raosuhas

/azp run

visingla-ms avatar Jan 31 '24 20:01 visingla-ms

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar Jan 31 '24 20:01 azure-pipelines[bot]

/azp run

visingla-ms avatar Feb 01 '24 20:02 visingla-ms

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar Feb 01 '24 20:02 azure-pipelines[bot]