azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

cdn: adding missing `x-ms-enum`'s

Open tombuildsstuff opened this issue 3 years ago • 28 comments

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [x] update existing version to fix swagger quality issue
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

tombuildsstuff avatar Feb 24 '22 14:02 tombuildsstuff

Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3295
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3295
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3295
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3398
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3398
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3398
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3451
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3451
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3451
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3508
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3508
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3508
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3561
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3561
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3561
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3618
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3618
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3618
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3671
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3671
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3671
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3677
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3677
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3677
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3719
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3719
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3719
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.

    ghost avatar Feb 24 '22 14:02 ghost

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Mar 13 '22 16:03 ghost

    This is waiting for the Service Team to review it...

    tombuildsstuff avatar Mar 14 '22 09:03 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Apr 03 '22 16:04 ghost

    Waiting on the service team to review it.

    tombuildsstuff avatar Apr 04 '22 05:04 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Apr 24 '22 16:04 ghost

    Waiting on the service team to review it.

    tombuildsstuff avatar Apr 27 '22 04:04 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar May 15 '22 16:05 ghost

    As above

    tombuildsstuff avatar May 17 '22 06:05 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Aug 07 '22 16:08 ghost

    As above

    tombuildsstuff avatar Aug 08 '22 04:08 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Aug 28 '22 16:08 ghost

    As above

    tombuildsstuff avatar Aug 28 '22 20:08 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Sep 18 '22 16:09 ghost

    As above..

    tombuildsstuff avatar Sep 19 '22 06:09 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Oct 09 '22 16:10 ghost

    Same as before: https://github.com/Azure/azure-rest-api-specs/pull/17987#issuecomment-1066574463

    tombuildsstuff avatar Oct 14 '22 19:10 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Oct 30 '22 16:10 ghost

    Still waiting for a review..

    tombuildsstuff avatar Oct 31 '22 07:10 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 27 '22 16:11 ghost

    Hi, @tombuildsstuff I help you to ping the service team on teams. Hope they will review your PR.

    ruowan avatar Nov 28 '22 08:11 ruowan

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jul 09 '23 16:07 ghost

    @ruowan any update here?

    tombuildsstuff avatar Jul 10 '23 06:07 tombuildsstuff

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR has breaking changes in the generated SDK for javascript (label: CI-BreakingChange-JavaScript). Refer to step 3 in the PR workflow diagram (even if your PR is for data plane, not ARM).