azure-relay-bridge icon indicating copy to clipboard operation
azure-relay-bridge copied to clipboard

Build MSI installer for Windows platform

Open ritchxu opened this issue 3 years ago • 1 comments

Sequel to https://github.com/Azure/azure-relay-bridge/pull/34 as master@fork was updated.

This PR adds a step in the CI to build the MSI installer artifact.

https://github.com/Azure/azure-relay-bridge/blob/10645d4994cf27cd6d2adce5793b520089b526b4/src/azbridge/azbridge.csproj#L195

In order to build the installer, Visual Studio 2019 Enterprise is required, hence using windows-2019 as the GitHub Actions runner.

https://github.com/Azure/azure-relay-bridge/blob/10645d4994cf27cd6d2adce5793b520089b526b4/src/azbridge/azbridge.csproj#L199

This PR also bumps the PackagingTargets package version to support Ubuntu 22

ritchxu avatar Jun 24 '22 03:06 ritchxu

Top

moovy2 avatar Aug 18 '22 21:08 moovy2

Thank you for the contribution and your efforts. I'm solving that a bit differently now and MSIs will be in the next release.

clemensv avatar Sep 15 '22 15:09 clemensv

@clemensv Thank you for the update! Would it be possible for an official docker image to be published as well?

We've been using a fork repository to publish docker image to a third-party registry. It would nice to have an official one so we can drop both the fork and unofficial docker image.

ritchxu avatar Sep 15 '22 16:09 ritchxu