ALZ-Bicep
ALZ-Bicep copied to clipboard
Update json file loading to use loadJsonContent
Overview/Summary
Updated json file loading to use loadJsonContent instead of json(loadTextContent. This approach allows for roughly 8x larger json files to be loaded by Bicep.
This PR fixes/adds/changes/removes
Breaking Changes
- Requires a version of Bicep that supports loadJsonContent
Testing Evidence
I made this change already in the SLZ variant of ALZ and successfully deployed the environment.
As part of this Pull Request I have
- [x ] Read the Contribution Guide and ensured this PR is compliant with the guide
- [ ] Ensured the resource API versions in
.bicepfile/s I am adding/editing are using the latest API version possible - [x ] Checked for duplicate Pull Requests
- [x ] Associated it with relevant GitHub Issues
- [ ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
- [x ] Ensured my code/branch is up-to-date with the latest changes in the
mainbranch - [x ] Performed testing and provided evidence.
- [ ] Updated one or more of the following tests (if required)
- [ x] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
- [ ] If relevant, created or updated Code Tours here
Hey KevinRabun, thanks for creating this PR.
We noticed that this PR is ammending some things related to policies (definitions or assignments) :mag:
Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.
So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.
However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.
Thanks from your friendly msft-bot.
@jtracey93 I removed the files we spoke update and updated this PR. I'll keep an eye on the linter though to make sure it is happy.
/azp run validateazcloud
Azure Pipelines successfully started running 1 pipeline(s).