ALZ-Bicep icon indicating copy to clipboard operation
ALZ-Bicep copied to clipboard

Update json file loading to use loadJsonContent

Open KevinRabun opened this issue 3 years ago • 1 comments
trafficstars

Overview/Summary

Updated json file loading to use loadJsonContent instead of json(loadTextContent. This approach allows for roughly 8x larger json files to be loaded by Bicep.

This PR fixes/adds/changes/removes

  1. Fixes

Breaking Changes

  1. Requires a version of Bicep that supports loadJsonContent

Testing Evidence

I made this change already in the SLZ variant of ALZ and successfully deployed the environment.

As part of this Pull Request I have

KevinRabun avatar Oct 17 '22 13:10 KevinRabun

Hey KevinRabun, thanks for creating this PR.

We noticed that this PR is ammending some things related to policies (definitions or assignments) :mag:

Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.

So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.

However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.

Thanks from your friendly msft-bot.

ghost avatar Oct 17 '22 13:10 ghost

@jtracey93 I removed the files we spoke update and updated this PR. I'll keep an eye on the linter though to make sure it is happy.

KevinRabun avatar Oct 20 '22 14:10 KevinRabun

/azp run validateazcloud

jtracey93 avatar Oct 20 '22 16:10 jtracey93

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 20 '22 16:10 azure-pipelines[bot]