ALZ-Bicep

ALZ-Bicep copied to clipboard

This PR fixes/adds/changes/removes

1. Update the markdown files to correspond with the parameters in the Bicep files.

As part of this Pull Request I have

• [x] Read the Contribution Guide and ensured this PR is compliant with the guide
• [x] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• [x] Checked for duplicate Pull Requests
• [x] Associated it with relevant GitHub Issues
• [ ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• [x] Ensured my code/branch is up-to-date with the latest changes in the main branch
• [ ] Performed testing and provided evidence.
• [ ] Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• [x] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• [ ] If relevant, created or updated Code Tours here

@johnlokerse let us know when this is good to review. I've placed the do not merge label on it for now.

@jtracey93 PR is ready for review. I went through every markdown file to review if the information is correct according to what is stated in the Bicep files. Also identified breaking changes that I have made, these are commented by me in the PR.

/azp run validateazcloud

Azure Pipelines successfully started running 1 pipeline(s).

@johnlokerse we got an error also on the validation pipeline but we know the name can be longer for these resources. Can we remove any places we have added min or max length as part of this PR please 👍

ERROR: {"code": "InvalidTemplate", "message": "Deployment template validation failed: 'The provided value for the template parameter 'parVirtualWanHubResourceId' is not valid. Length of the value should be less than or equal to '50'. Please see https://aka.ms/arm-template/#parameters for usage details.'.", "additionalInfo": [{"type": "TemplateViolation", "info": {"lineNumber": 14, "linePosition": 21, "path": "properties.template.parameters.parVirtualWanHubResourceId.maxLength"}}]}

@johnlokerse we got an error also on the validation pipeline but we know the name can be longer for these resources. Can we remove any places we have added min or max length as part of this PR please 👍

ERROR: {"code": "InvalidTemplate", "message": "Deployment template validation failed: 'The provided value for the template parameter 'parVirtualWanHubResourceId' is not valid. Length of the value should be less than or equal to '50'. Please see https://aka.ms/arm-template/#parameters for usage details.'.", "additionalInfo": [{"type": "TemplateViolation", "info": {"lineNumber": 14, "linePosition": 21, "path": "properties.template.parameters.parVirtualWanHubResourceId.maxLength"}}]}

@jtracey93 Reverted my changes regarding minLength and maxLength

Hey @johnlokerse,

Thanks for this we are reviewing :)

/azp run validateazcloud

Azure Pipelines successfully started running 1 pipeline(s).