A few corrections

Open jordi-prats opened this issue 8 years ago • 3 comments

I think you might be interested in these corrections:

the fix for some integer division issues
the correction of the longwave coefficient for cloud_mode=3 and cloud_mode=4
a correction of the equation adding snow to the surface layer when there is no ice

Best, Jordi

Dec 08 '17 14:12 jordi-prats

Hey Jordi Thanks a lot for finding these issues and the fixes, much appreciated ... I'll double check over them (but I think your right in all cases), and then we will merge into our master. Cheers Matt

Dec 09 '17 03:12 matthipsey

Dear Jordi:

I wonder the L_outfl and W_outfl are the length and width of semi-axis or axis?

Cheers

Dec 10 '17 20:12 mcxmcx

Of course Matt, glad to help. However, as noticed by mcxmcx, I got it wrong with the 11f58c6 commit(Fix basin length at outflow height). Thanks for pointing it out, mcxmcx.

Dec 11 '17 15:12 jordi-prats

@matthipsey @casper-boon can this PR be closed so there isn't an open PR from 2017?

Aug 29 '24 14:08 rqthomas