appsflyer-unity-plugin icon indicating copy to clipboard operation
appsflyer-unity-plugin copied to clipboard

Cannot build with xCode 15.3

Open IoannisFMG opened this issue 1 year ago • 15 comments

Hello!

I just updated xCode to 15.3 and there seems to be an ISO C99 issue with the AppsFlyer+AppController.mfile. The attached image is a screenshot from xCode 15.2 where the issue

Type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int

marked as a warning has now become an error. The fix seems to be just a simple cast, but still the build fails.

I am using an older version of the SDK, but I have checked the repo and the code for the specific method hasn't changed yet. Could you please take a look at it?

Cheers!

Screenshot 2024-03-06 at 13 44 22

IoannisFMG avatar Mar 06 '24 11:03 IoannisFMG

I have the same problem, waiting for a fix.

victor-kallai avatar Mar 06 '24 12:03 victor-kallai

I have got the same issue.

juaprebo avatar Mar 06 '24 13:03 juaprebo

Also seeing this.

StuWebstMW avatar Mar 06 '24 18:03 StuWebstMW

As a temporary workaround, seems that accepting Xcode's suggested fix for that error allows you to build at least. To save doing that every build you can make the change to the package version in /Library/PackageCache/appsflyer-unity-plugin@xxxxxxxxxx/AppsFlyer+AppController.m (line 144 in the version I have), just add int before (UIBackgroundFetchResult), i.e.;

return ((BOOL(*)(id, SEL, UIApplication*, NSDictionary*, int(UIBackgroundFetchResult)))__original_didReceiveRemoteNotification_Imp)(self, _cmd, application, userInfo, nil);

champie avatar Mar 07 '24 15:03 champie

Having the same issue!

The fix above works!

Duloinc avatar Mar 10 '24 12:03 Duloinc

The previous method definition is BOOL __swizzled_didReceiveRemoteNotification(id self, SEL _cmd, UIApplication* application, NSDictionary* userInfo, void (^UIBackgroundFetchResult)(void)). Therefore, I modified it to: return ((BOOL()(id, SEL, UIApplication, NSDictionary*,void (^)(void)))__original_didReceiveRemoteNotification_Imp)(self, _cmd, application, userInfo, nil); It seems to be fine.

st21a1 avatar Mar 11 '24 10:03 st21a1

when sdk will be updated?

jedai7 avatar Mar 12 '24 15:03 jedai7

same issue, need fix ASAP

serzit avatar Mar 18 '24 10:03 serzit

same issue, need fix ASAP

If you need a fix ASAP, downgrade Xcode to 15.2. Another fix has already been mentioned.

Decavoid avatar Mar 18 '24 11:03 Decavoid

Have the same issue, fix the error please...

NudeNULL avatar Mar 27 '24 11:03 NudeNULL

Downgraded to xcode 15.2 to avoid the suggested workaround, waiting for a fix 🙏

Gnts avatar Mar 27 '24 11:03 Gnts

+1

TDS-Arikaton avatar Mar 28 '24 12:03 TDS-Arikaton

It seems this issue has been fixed at the Appsflyer's ios SDK (https://support.appsflyer.com/hc/en-us/articles/115001224823-AppsFlyer-iOS-SDK-release-notes)

Could we please have the this fix on unity's SDK as well?

gsteinkirch-bytro avatar Apr 06 '24 02:04 gsteinkirch-bytro

+1 waiting for a resolution on this...

andy-block avatar Apr 06 '24 09:04 andy-block

Is this resolved with the latest release?

ersagunkuruca avatar Apr 09 '24 07:04 ersagunkuruca

Hi, we will release the fix with a new version

af-vero avatar Apr 14 '24 16:04 af-vero

It's obvious that it will be fixed in a new version. We won't be able to update our apps in two weeks time. Updating and releasing them also takes time. We'd like to have a timeframe though, please.

IoannisFMG avatar Apr 15 '24 07:04 IoannisFMG

till the end of the week

af-vero avatar Apr 15 '24 12:04 af-vero

released in version 6.14.0

af-vero avatar Apr 16 '24 12:04 af-vero