Andreas Madsen

Results 85 comments of Andreas Madsen
trafficstars

+1 just got 5 pull requests, there will break compatibility with node 0.6 and node 0.4.

A big problem we faced was that `async function`s don't depend on `global.Promise` but instead the internal `[[Promise]]`. It is thus not possible to instrument `async function` in the browser....

> silent errors can be deadly sure, but clarify shouldn't make them silent. It just shortens them. > It would be good to indicate that these calls have been filtered...

> The longjohn module does it when showing stack traces across nextTick by creating a dummy CallSite object and setting its getFileName() property to a divider. That is just a...

> So what would be best is if we made longjohn compatible with the stack-chain formatter. That would be lovely :) But fortunately my policy with my stack trace lineup...

Adding an `enable` and a `disable` function would be fine, if `require('clarify')` enables immediately such `node -r clarify` is possible. The same could perhaps be done for `trace`, but this...

This is nice. Could you provide some more information about what you think is missing? From a quick look: Pareto median and variance is missing, it looks like they are...

Is there something that is impossible right now, due to recent changes? We already expose the top of the stack, though JS and C++ APIs. The rest of the stack...

@bjouhier I understand. However, implementing those functions would legalize clearing the state stack that is used for very critical sanity checks. I don't think that is something we would want...

> The sampled value goes in an instance of https://www.npmjs.com/package/hdr-histogram-js, which provides all the calculations. This is probably not the best data structure for this, as we do not have...