ember-widgets icon indicating copy to clipboard operation
ember-widgets copied to clipboard

Published 20 hours ago • verified publisher icon Addepar

not all templates are pre-compiled in minified build

Open stefanpenner opened this issue 11 years ago • 2 comments

steps to reproduce:

  1. grunt
  2. search dist/ember-widgets.min.js for Ember.Handlebars.compile(

expectation:

in the minified build all templates to be precompiled, so that only the handlebars runtime is required for production builds.

  • [x] prefer templates over templateNames https://github.com/Addepar/ember-widgets/issues/23
  • [ ] precompile defaultTemplate

stefanpenner avatar Mar 20 '14 13:03 stefanpenner

for pre compilation of templates, ember itself does the following:

https://github.com/emberjs/ember.js/blob/2556dcf5e764c4c3c98a1f8eaa19e60766473697/packages_es6/ember-handlebars/lib/controls/select.js#L339

and then at build time, we do the precompilation + inline the template.

stefanpenner avatar Mar 20 '14 14:03 stefanpenner

I'd love to see this working. Now that ember-i18n doesn't require the full version of handlebars (as of 2.1.0), I would like to switch over to the runtime. Alternatively, if #68 were fixed, this would also resolve my problem as I'm not using AccordianWidget.

blimmer avatar Aug 14 '14 18:08 blimmer