sfmc-devtools icon indicating copy to clipboard operation
sfmc-devtools copied to clipboard

#162: print time it takes to run retrieve/deploy command

Open tuliodnw opened this issue 3 years ago • 1 comments

PR details

What is the purpose of this pull request? (put an "X" next to an item)

Please delete options that are not relevant.

  • [x] Other, please explain:

What changes did you make? (Give an overview)

added 2 functions in util, one to get the time in ms before function and a second one that calculates and prints the time passed between the first function in ms.

Is there anything you'd like reviewers to focus on?

the stopTimer in index.js, is adding a stopTimer before every return the best way?

Checklist

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] ESLint & Prettier are not outputting errors or warnings //after removing the warnings and saving, the warnings appear again

tuliodnw avatar Jul 22 '22 15:07 tuliodnw

There is always the option to have it in index.js or in cli.js - but let's check this out first the way you built it.

JoernBerkefeld avatar Jul 24 '22 06:07 JoernBerkefeld

not going to use this solution. new PR will be created

JoernBerkefeld avatar Jul 26 '23 07:07 JoernBerkefeld