OpenTimelineIO icon indicating copy to clipboard operation
OpenTimelineIO copied to clipboard

Fix non latin symbols decoding in adapters

Open kalemas opened this issue 2 years ago • 4 comments

Link the Issue(s) this Pull Request is related to.

Fixes #1321

Summarize your change.

As Py2 support is dropped we should be free to commit utf-8 encoding in Python Adapters to handle UTF in input data.

kalemas avatar Feb 01 '24 22:02 kalemas

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: kalemas / name: Konstantin Maslyuk (cfeb9049f2f8c5cca64a99743b3dcfa9fb65e959)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (013fe04) 79.83% compared to head (cfeb904) 79.83%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files         197      197           
  Lines       21814    21814           
  Branches     4362     4362           
=======================================
  Hits        17416    17416           
  Misses       2233     2233           
  Partials     2165     2165           
Flag Coverage Δ
py-unittests 79.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-opentimelineio/opentimelineio/adapters/adapter.py 89.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 013fe04...cfeb904. Read the comment docs.

codecov-commenter avatar Feb 01 '24 22:02 codecov-commenter

@kalemas We've addressed the windows build issues in the HEAD of the current main branch, would you mind rebasing on top of that so we can get a clean build? Sorry about the confusion!

reinecke avatar Feb 15 '24 18:02 reinecke

rebasing on top of that so we can get a clean build?

@reinecke Done.

kalemas avatar Feb 17 '24 11:02 kalemas