stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Published 20 hours ago • verified publisher icon AUTOMATIC1111

dont send server address in a-href

Open light-and-ray opened this issue 1 year ago • 4 comments

Description

Gradio sets these tags automatically when generates hyperlinks from markdown rel="noopener noreferrer" I've added them into webui's html

You can see users' non-local server addresses (e.g. --share or their hosting) in github's repo statistics for example, when they go to the repo via Extensions tab. Other sites can see them too. This PR fixes this

Checklist:

light-and-ray avatar Apr 26 '24 09:04 light-and-ray

I think it might be possible to just set Referrer-Policy header no-referrer to automatically apply to the entire web page https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy

w-e-w avatar Apr 27 '24 09:04 w-e-w

  • try this https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/15641

w-e-w avatar Apr 27 '24 10:04 w-e-w

I thinks it's good to merge both

light-and-ray avatar Apr 29 '24 09:04 light-and-ray

I thinks it's good to merge both

in my opinion if the global one works then just the global one is better less clutter the the code

w-e-w avatar Apr 29 '24 09:04 w-e-w

I merged the other one and if it achieves the result, I don't want to add more changes. If this change is still wanted, reopen the PR.

AUTOMATIC1111 avatar Jun 08 '24 08:06 AUTOMATIC1111