vault-web icon indicating copy to clipboard operation
vault-web copied to clipboard

added ability to save JSON as secrete values

Open gregkeys opened this issue 9 years ago • 5 comments

This adds the ability to read and save Json values stored in vault

gregkeys avatar Sep 19 '16 05:09 gregkeys

Thanks for the PR. Can you explain this a bit more? Are you not currently able to save JSON values?

AMeng avatar Sep 19 '16 15:09 AMeng

without this PR json looks like [Object Object] and if you save that it will replace the json values

On Sep 19, 2016 8:58 AM, "Alex Meng" [email protected] wrote:

Thanks for the PR. Can you explain this a bit more? Are you not currently able to save JSON values?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AMeng/vault-web/pull/3#issuecomment-248035036, or mute the thread https://github.com/notifications/unsubscribe-auth/ADIV-ydraXa6SeE6zKE58hZy8ggw5Ariks5qrrEigaJpZM4KAI4E .

gregkeys avatar Sep 19 '16 19:09 gregkeys

I'm not able to reproduce the bug. Can you provide example values that cause this? When I enter a JSON string into the value of a secret, it saves and loads fine.

image

Or am I misunderstanding the issue?

AMeng avatar Sep 19 '16 20:09 AMeng

when we first implemented your ui our values came from the command line perhaps that was part of the problem, vault write secret/foo bar='{"one":"two"}'

also try this {"one":"two"} with the quotes

On Sep 19, 2016 1:39 PM, "Alex Meng" [email protected] wrote:

I'm not able to reproduce the bug. Can you provide example values that cause this? When I enter a JSON string into the value of a secret, it saves and loads fine.

[image: image] https://cloud.githubusercontent.com/assets/192336/18648063/28db0b0a-7e76-11e6-9556-c841b21db6a0.png

Or am I misunderstanding the issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AMeng/vault-web/pull/3#issuecomment-248119040, or mute the thread https://github.com/notifications/unsubscribe-auth/ADIV--5S2_kXOL9AwRiKYFaYGIzHWqZtks5qrvMcgaJpZM4KAI4E .

gregkeys avatar Sep 19 '16 21:09 gregkeys

I'm still not able to reproduce this. I tried all the values you suggested from both the UI and the CLI. Is there any way you can provide a more complete example?

AMeng avatar Sep 20 '16 15:09 AMeng