LibertyBans icon indicating copy to clipboard operation
LibertyBans copied to clipboard

[Feature Request]: Checks

Open BlueTree242 opened this issue 4 years ago • 11 comments

I have confirmed that ...

  • [X] There is no duplicate feature request.

Description

so, on a smp server (and other servers too), a mod can be annoying and ban innocent players, how could we prevent that??

Here is how, the plugin does checks before punishing a player, still not clear, ill give more details.

This is an example list of checks

  • Anticheat detected before
  • Reported by a player before
  • Player has sent too many messages racently
  • Player swore alot
  • Player placed alot of redstone blocks (for smps)
  • Player tried to ping everyone on discordsrv
  • Player is not brand new, but this doesn't seem so good

I am not requesting the stuff above, the above should be added by other plugins via the api

For example

registerCheck("cheated-before", player -> {
 if (anticheat.playerDidCheat(player)) return true;
else return false;
});

The first parameter is the thing used for bypass perms, like libertybans.bypasscheck.cheated-before

This would make this plugin more powerful than any other punishment plugin.

I also have another way of checks, you can look and see which is better

Checks depend on a number, for example 3 checks are true then 3, 0 are true then 0, with their permission bypass libertybans.bypasschecks.1. This permission allow the staff member to punish players with 1+ check true. Thru the api it would be an int instead of string to allow a check to give more than 1.. Like if staff must punish with 2 checks true but a check is powerful it can take 3 alone.. So he can be punished even only 1 check is true But powerful enough

It would be cool if you do both, how?? By making a staff member able to bypass a check and it's value will always be as if it was true when trying punish. this would mean both int and string params present on the api

Also don't forget to make the check stuff available on the punish event (the one that fire before the actual punishment)

Result for owners:

Less chance of false punishments

BlueTree242 avatar Nov 17 '21 20:11 BlueTree242

I think your feature request is interesting, but sounds like something that should be done by another plugin. Adding many types of checks can be boilerplate for those who don't need it, and can hurt preformance, not to speak about the maintance costs.

LibertyBans is kinda like a tool, a utility other plugins should hook into. I'd love to see anticheats making addons or implementing LibertyBans support, I think if you are looking for something like that for as an example..You can code it! ^_^

KoxSosen avatar Nov 17 '21 21:11 KoxSosen

so, on a smp server (and other servers too), a mod can be annoying and ban innocent players, how could we prevent that??

Remove the mod :p

KoxSosen avatar Nov 17 '21 21:11 KoxSosen

I think your feature request is interesting, but sounds like something that should be done by another plugin. Adding many types of checks can be boilerplate for those who doesn't need it, and can hurt preformance, not to speak about the maintance costs.

LibertyBans is kinda like a tool, a utility other plugins should hook into. I'd love to see anticheats making addons or implementing LibertyBans support, I think if you are looking for something like that for as an example..You can code it! ^_^

I didn't mention it should be off by default sorry. This beeing built in the plugin can get the plugin instantly on top

BlueTree242 avatar Nov 17 '21 21:11 BlueTree242

so, on a smp server (and other servers too), a mod can be annoying and ban innocent players, how could we prevent that??

Remove the mod :p

Well yeah doesnt work on big servers with those busy owners who have no time to see if players are innocent or can't proof they are

BlueTree242 avatar Nov 17 '21 21:11 BlueTree242

No one would hook into an addon so it cant be like that

BlueTree242 avatar Nov 17 '21 21:11 BlueTree242

About performance, some plugins checks can be slow, just adding a list of disabled checks would help

BlueTree242 avatar Nov 17 '21 21:11 BlueTree242

so, on a smp server (and other servers too), a mod can be annoying and ban innocent players, how could we prevent that??

Remove the mod :p

Well yeah doesnt work on big servers with those busy owners who have no time to see if players are innocent or can't proof they are

Good point, but from my experience large serburs usually have a staff team, and instead of relying on anticheat bans, they usually use the anticheat alerts as a way to inform staff members about potencial cheaters.

KoxSosen avatar Nov 17 '21 21:11 KoxSosen

so, on a smp server (and other servers too), a mod can be annoying and ban innocent players, how could we prevent that??

Remove the mod :p

Well yeah doesnt work on big servers with those busy owners who have no time to see if players are innocent or can't proof they are

Good point, but from my experience large serburs usually have a staff team, and instead of relying on anticheat bans, they usually use the anticheat alerts as a way to inform staff members about potencial cheaters.

Yes for anticheat, it would check if they cheated before as it would be a proof this is a legit ban, note these checks only happen on small staff like trial or mod

BlueTree242 avatar Nov 17 '21 21:11 BlueTree242

The feature may be useless for some people, but this can make the plugin on top even if low server use it

BlueTree242 avatar Nov 17 '21 22:11 BlueTree242

I definitely appreciate the proposal for such an expansive feature – there has been no other feature request to-date which is as ambitious as this one (I consider that a good thing).

However, this does seem like a feature which would belong in another plugin. Nevertheless, LibertyBans should make this feature possible using the API – that is, LibertyBans should provide enough API features to enable another plugin to build this kind of system on top of it.

If there was a plugin, either existing or in-progress, that provided such a system of checks, then we could see whether the LibertyBans API is adequate to support the checks system. If the API is inadequate, that would be good reason to add API features.

Regarding the popularity of LibertyBans, I think that if another plugin provided this system of checks, and was built on top of LibertyBans, that would similarly boost LibertyBans' popularity, and in a manner compatible with the design and scope of LibertyBans. That design and scope being to avoid features, where possible, which are tangential or additional to a basic system of punishment administration and enforcement. If a feature can be adequately and efficiently implemented in another plugin, then it should probably not be included in LibertyBans.

A248 avatar Nov 20 '21 23:11 A248

I agree with A2 here - this seems best fit for an 'addon'-type plugin.

lokka30 avatar Apr 22 '22 10:04 lokka30