cl-flamegraph icon indicating copy to clipboard operation
cl-flamegraph copied to clipboard

Bad `func` slot type + SBCL 2.1.2 dropped support sb-sprof:map-trace-samples

Open Ambrevar opened this issue 4 years ago • 8 comments

The func slot of the node class has type (or string sb-di::compiled-debug-fun) but its initform is nil, which does not match.

This is an issue on modern SBCLs.

Either the initform needs to be set to "" or null must be added to the types.

Ambrevar avatar Feb 06 '21 15:02 Ambrevar

I did not encounter this error. How it can be reproduced?

сб, 6 февр. 2021 г., 18:07 Pierre Neidhardt [email protected]:

The func slot of the node class has type (or string sb-di::compiled-debug-fun) but its initform is nil, which does not match.

This is an issue on modern SBCLs.

Either the initform needs to be set to "" or null must be added to the types.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/40ants/cl-flamegraph/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGB67BVE4YDXQXWTSZ6HTS5VLJXANCNFSM4XGLRUOA .

svetlyak40wt avatar Feb 06 '21 15:02 svetlyak40wt

If you load the system with SBCL 2.1.0, it outputs a type warning.

Ambrevar avatar Feb 06 '21 15:02 Ambrevar

I've seen SBCL 2.1.2 dropped support of sb-sprof:map-trace-samples.

@Ambrevar do you know if they are replaced this function?

svetlyak40wt avatar Mar 12 '21 10:03 svetlyak40wt

No clue, I've only tested with SBCL 2.1.0 so far.

Ambrevar avatar Mar 12 '21 10:03 Ambrevar

I suppose this is still an issue? I just tried to install this with no luck.

fosskers avatar Aug 14 '23 07:08 fosskers

Ah, I see now PR #12 ! And it's working great.

fosskers avatar Aug 14 '23 07:08 fosskers

Oh, I completely missed that PR! Thank you for reminding and checking that PR! Now it is merged!

svetlyak40wt avatar Aug 14 '23 09:08 svetlyak40wt

Thank you!

fosskers avatar Aug 14 '23 23:08 fosskers