comfyui-workspace-manager

comfyui-workspace-manager copied to clipboard

I frequently have problems saving my workflow and I notice a bunch of errors in the dev tools console.

I think it might be workspace-manager that is causing the issue.

I don't think my workflow is particularly large, but maybe... :)

Hi can you please expand the error so I can view the callstack of the error? It would be very helpful for debugging, thank you very much!

---

From: Aaron C. de Bruyn @.> Sent: Wednesday, April 3, 2024 10:09:46 PM To: 11cafe/comfyui-workspace-manager @.> Cc: Subscribed @.***> Subject: [11cafe/comfyui-workspace-manager] Failed to execute setItem on Storage: Setting the value of workflow:blah exceeded the quota (Issue #335)

I frequently have problems saving my workflow and I notice a bunch of errors in the dev tools console.

I think it might be workspace-manager that is causing the issue.

Screenshot.from.2024-04-03.07-05-52.png (view on web)https://github.com/11cafe/comfyui-workspace-manager/assets/158380/5b7a1cd8-2f80-491f-bc25-68308d41d1c8

I don't think my workflow is particularly large, but maybe... :)

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/335, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOOEVOA6HSBUYIBL45LY3QESVAVCNFSM6AAAAABFVMXNT6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDGMBUGU4DQNQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Sorry for the delay. It took me a bit to grab it.

I'm noticing this starts happening after leaving the browser open and generating images for hours. Eventually it slows to a crawl and stops saving workflows. If I hammer the save button a handful of times it will eventually save instead of throwing the error, and then I close/re-open the tab to free up resources and it's back to being responsive.

it seems there are 2 issues:

1. you run out of the localstorage quota (usually 10mb)... did. you have lots of things stored in localstorage? you can F12 -> Application -> Localstorage to inspect

2. the our disk db backup .json file becomes too large. I added some try catch around it so it won't throw (https://github.com/11cafe/comfyui-workspace-manager/commit/e6c502cd7a835ffa4c05bca878cc6436f0d18c76). Also we plan to move away from pure json files for db backup and instead using sqlite or some server db for db backup.

Hmm...Chrome doesn't tell me how much space I'm using for localstorage...but inspecting it doesn't show too many items...but "workflow" probably has a lot of subkeys and stuff. Doing some searching shows that Edge is the only browser that lets you see how much localstorage you are using.