0x-mesh
0x-mesh copied to clipboard
Enforce code formatting for both Go and TypeScript
We should enforce formatting rules for Go and TypeScript as part of our CI process. This should include goimports, TSLint, and Prettier. It is not uncommon to see pure formatting changes pop up in PRs and this distracts from actual meaningful changes.
I've noticed this commonly happens with Go files that have build tags, as it can sometimes cause them to not be recognized/auto-formatted by your editor.
Expected Behavior
There should be no formatting-only changes in any PRs. All formatting should be normalized and enforced by CI so that they only changes in PRs are actual code changes.
Current Behavior
We do run make lint in CI but it doesn't seem to cover everything. We sometimes still see some formatting-only changes in PRs.