starfish icon indicating copy to clipboard operation
starfish copied to clipboard

Published 20 hours ago • verified publisher icon indeedeng

Use conditional requests to avoid rate limiting problems

Open danisyellis opened this issue 4 years ago • 9 comments

See this link for more info conditional requests: https://developer.github.com/v3/#conditional-requests We could use either ETags or the If-Modified-Since header.

Making a conditional request and receiving a 304 response does not count against our rate limit, so it could help any rate limiting issues. We (at Indeed) haven't seen a huge problem with this, but a larger org almost certainly would.

danisyellis avatar Jun 08 '20 22:06 danisyellis

Hi, @danisyellis I would like to take up this task as my first contribution. It would be great to learn something out of it

rajaSahil avatar Oct 02 '20 04:10 rajaSahil

Hi @rajaSahil That would be fantastic. let me know if you have any questions.

danisyellis avatar Oct 05 '20 19:10 danisyellis

Hi @rajaSahil I just wanted to let you know that I'm doing virtual "office hours" tomorrow (maybe today when you read this) October 14th at 4pm PST https://organize.mlh.io/participants/events/5666-virtual-starfish-office-hours. And then again on October 26th from 2-3pm PST. https://organize.mlh.io/participants/events/5668-virtual-starfish-office-hours If you have any questions about this ticket, you're welcome to pop in then and I can try to answer them or work through it with you.

danisyellis avatar Oct 14 '20 04:10 danisyellis

Thanks, @danisyellis I will try to join the virtual office, although it will be early morning here(4:30 am).

rajaSahil avatar Oct 14 '20 07:10 rajaSahil

Oof, that's really early! We can also set up some other time that works better for each of our timezones!

danisyellis avatar Oct 14 '20 08:10 danisyellis

Yes, that would be really helpful.

rajaSahil avatar Oct 14 '20 08:10 rajaSahil

Hi @rajaSahil are you still interested in working on this? If not, I'll unassign you.

danisyellis avatar Dec 09 '20 02:12 danisyellis

@danisyellis Can I work on this task? I would be the first one in my open source journey. So please assign it to me if possible.

shehriyarnadeem avatar Jul 31 '22 20:07 shehriyarnadeem

Hi @shehriyarnadeem. I will assign it to you. The primary maintainer (Dani) is unavailable right now, but I can try to help with any questions you might have. In particular, I encourage you to outline what solution you are going to try, to ensure that it will meet the requirements.

When I tried the earlier docs link, it didn't seem to take me to a relevant section. I found this, which might be helpful, although I only took a quick glance at it: https://docs.github.com/en/rest/overview/resources-in-the-rest-api#conditional-requests

kevindigo avatar Aug 01 '22 21:08 kevindigo